Closed Bug 886099 Opened 11 years ago Closed 11 years ago

Remove "Manage CRLs..." button from Preferences

Categories

(SeaMonkey :: Security, defect)

Product:
SeaMonkey
Component:
Security
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.20 unaffected, seamonkey2.21 verified, seamonkey2.22 fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.22
Tracking Flags:
Tracking Status
seamonkey2.20 --- unaffected
seamonkey2.21 --- verified
seamonkey2.22 --- fixed

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(2 files)

Possible patch
11.37 KB, patch
iannbugzilla
: review+
philip.chee
: feedback+
Details | Diff | Splinter Review
Branch patch
8.74 KB, patch
iannbugzilla
: review+
iannbugzilla
: approval-comm-aurora+
Details | Diff | Splinter Review 
Bug 867465 removed the window that the button opens.

As there is only one thing left in that pane, we should probably move it to another pane.

Help will also need to be updated.

And there are string changes too, which is annoying 1 day before uplift...
Attached patch Possible patch — — Splinter Review 
No help changes here. (Any chance they could be done separately?)
Attachment #766496 - Flags: review?(iann_bugzilla)
Attachment #766496 - Flags: feedback?(philip.chee)
RuntimeError: File "chrome/common/pref/pref-validation.dtd" not found in c:\t1\hg\comm-central\suite\locales\en-US
Comment on attachment 766496 [details] [diff] [review]
Possible patch

> RuntimeError: File "chrome/common/pref/pref-validation.dtd" not found
> in c:\t1\hg\comm-central\suite\locales\en-US

f=me with the locale jar.mn fixed.
Attachment #766496 - Flags: feedback?(philip.chee) → feedback+
Comment on attachment 766496 [details] [diff] [review]
Possible patch

r=me with the locale jar fix and a separate bug raised for the help changes.
Attachment #766496 - Flags: review?(iann_bugzilla) → review+
If the Help updates are just about removing the "Validation Settings" file and moving the OCSP section over to the "Certificates" help, I can take care of that in a follow-up bug (despite not being knowledgeable on this topic).
Blocks: 892060
Pushed comm-central changeset d2993f7c5ebc.
Status: NEW → RESOLVED
Closed: 11 years ago
status-seamonkey2.22: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.22
Comment on attachment 766496 [details] [diff] [review]
Possible patch

[Approval Request Comment]
Regression caused by (bug #): 867465
User impact if declined: Button that could lock up the Preferences window
Risk to taking this patch (and alternatives if risky): Some, could probably write a simpler branch patch that just hides the faulty UI instead.
String changes made by this patch: Lots
Attachment #766496 - Flags: approval-comm-aurora?
Looks like this may be needed for Thunderbird too.
Yes, TB has a "Revocation Lists" button in Advanced > Certificates (same as Firefox).
Assignee: nobody → neil
Comment on attachment 766496 [details] [diff] [review]
Possible patch

Couldn't you just pull pref-validation.dtd into pref-certs.xul and thus remove any string changes for aurora?
Pushed comm-central changeset d22aca802963 because I forgot comment #3. Oops.

(In reply to Ian Neal from comment #10)
> Couldn't you just pull pref-validation.dtd into pref-certs.xul and thus
> remove any string changes for aurora?

Indeed I could; I thought at one point that I had new strings but that's not effectively the case.
Attached patch Branch patch — — Splinter Review 

        Attachment #773664 -
        Flags: review?(iann_bugzilla)

    
    

    
  
Comment on attachment 773664 [details] [diff] [review]
Branch patch

[Triage Comment]
r=me
a=me for comm-aurora

        Attachment #773664 -
        Flags: review?(iann_bugzilla)

        Attachment #773664 -
        Flags: review+

        Attachment #773664 -
        Flags: approval-comm-aurora+

    
    

    
  
(In reply to :aceman from comment #8)
> Looks like this may be needed for Thunderbird too.

I've filed bug 892255 on the TB part before we forget about it.

    
    

    
  
Branch patch looks good in the aurora nightly builds, Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 SeaMonkey/2.21a2, 20130723013001.

          status-seamonkey2.21:
          fixed → verified

    
    

    
  
Comment on attachment 766496 [details] [diff] [review]
Possible patch

Neil, I think you can cancel the approval-comm-aurora? here as the other patch was already approved and checked in for aurora.

    
    

    
  
Does the Seamonkey project really has to do all the non-sense done to Firefox?

Think of CAs which do not provide OCSP service.
Not to speak of the privacy concerns regarding OCSP.

    
    

    
  
(In reply to michael from comment #18)
> Does the Seamonkey project really has to do all the non-sense done to
> Firefox?
> 
> Think of CAs which do not provide OCSP service.
> Not to speak of the privacy concerns regarding OCSP.

If you had read the dependent bug 886099 you will have seen there was no choice but also that there is a command line tool available - https://developer.mozilla.org/en-US/docs/NSS/tools/NSS_Tools_crlutil

    
    

    
  
Comment on attachment 766496 [details] [diff] [review]
Possible patch

clearing obsolete approval request

        Attachment #766496 -
        Flags: approval-comm-aurora?

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: