Closed Bug 886116 Opened 6 years ago Closed 6 years ago

Port | Bug 698565 - stop excluding keys when calling JSON.stringify() and follow-ups | to SeaMonkey

Categories

(SeaMonkey :: Session Restore, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.22

People

(Reporter: pppx, Assigned: pppx)

References

Details

Attachments

(8 files, 2 obsolete files)

Patches, splitted as in original bug, following
Assignee: nobody → pppx
Status: NEW → ASSIGNED
Attachment #766432 - Flags: review?(iann_bugzilla)
Attached patch Patch 2 - tabStillLoading (obsolete) — Splinter Review
Attachment #766433 - Flags: review?(iann_bugzilla)
Attachment #766434 - Flags: review?(iann_bugzilla)
Attached patch Patch 4 - hostsSplinter Review
Attachment #766435 - Flags: review?(iann_bugzilla)
Attached patch Patch 5 - host+scheme (obsolete) — Splinter Review
Attachment #766436 - Flags: review?(iann_bugzilla)
Attachment #766438 - Flags: review?(iann_bugzilla)
Attachment #766436 - Attachment description: Bug 886116 Patch 5 - host+scheme → Patch 5 - host+scheme
For some reasons two patches didn't apply cleanly on test build system, remaked them
Attachment #766433 - Attachment is obsolete: true
Attachment #766433 - Flags: review?(iann_bugzilla)
Attachment #766586 - Flags: review?(iann_bugzilla)
Attachment #766436 - Attachment is obsolete: true
Attachment #766436 - Flags: review?(iann_bugzilla)
Attachment #766587 - Flags: review?(iann_bugzilla)
Attachment #766586 - Attachment description: Bug 886116 Patch 2 - tabStillLoading v2 → Patch 2 - tabStillLoading v2
Attachment #766432 - Flags: review?(iann_bugzilla) → review+
Attachment #766434 - Flags: review?(iann_bugzilla) → review+
Attachment #766435 - Flags: review?(iann_bugzilla) → review+
Attachment #766438 - Flags: review?(iann_bugzilla) → review+
Attachment #766586 - Flags: review?(iann_bugzilla) → review+
Attachment #766587 - Flags: review?(iann_bugzilla) → review+
Keywords: checkin-needed
Per today meeting comments
Flags: needinfo?(bugspam.Callek)
Keywords: checkin-needed
Whiteboard: checkin-suite-needed
Pushed to comm-central:
https://hg.mozilla.org/comm-central/rev/a60fa670d720
https://hg.mozilla.org/comm-central/rev/bddf10c236b3
https://hg.mozilla.org/comm-central/rev/8fd8bb9a0da4
https://hg.mozilla.org/comm-central/rev/f1d8eaf50d5d
https://hg.mozilla.org/comm-central/rev/6be882994daa
https://hg.mozilla.org/comm-central/rev/d6e582202f1e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: needinfo?(bugspam.Callek)
Resolution: --- → FIXED
Whiteboard: checkin-suite-needed
Target Milestone: --- → seamonkey2.22
I backed out Part 1:
https://hg.mozilla.org/comm-central/rev/1915f5d868db
r=Neil for bustage backout a=Callek for CLOSED TREE
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This wraps our special extra browser data into a separate object which is then hidden from JSON.stringify thus allowing Patch 1 to be relanded.
Attachment #777118 - Flags: review?(iann_bugzilla)
Comment on attachment 777118 [details] [diff] [review]
Patch 0 - browserData

Seems fine r=me
Attachment #777118 - Flags: review?(iann_bugzilla) → review+
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/b16446dc349d
http://hg.mozilla.org/comm-central/rev/9daad1aa9c75
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Comment on attachment 766435 [details] [diff] [review]
Patch 4 - hosts

>           delete this._windows[ix];
>+          delete this._internalWindows[ix];
...
>-      delete this._windows[aWindow.__SSi];
>+      delete this._internalWindows[aWindow.__SSi];
This change looks wrong; I don't see the line being deleted in the Firefox patch.
(In reply to Phoenix from comment #16)
> Huh?
> https://bug698565.bugzilla.mozilla.org/attachment.cgi?id=572623
> 2nd and 5th change

My point exactly:

>           delete this._windows[ix];
>+          delete this._internalWindows[ix];
...
>       delete this._windows[aWindow.__SSi];
>+      delete this._internalWindows[aWindow.__SSi];

Note that there's no - on the Firefox versions.
This should back SS to working state.
Attachment #784871 - Flags: review?(neil)
(In reply to neil@parkwaycc.co.uk from comment #17)
> >       delete this._windows[aWindow.__SSi];
> >+      delete this._internalWindows[aWindow.__SSi];
> 
> Note that there's no - on the Firefox versions.
I'm blind :(
Attachment #784871 - Flags: review?(neil) → review+
Keywords: checkin-needed
Does this change also need to land on aurora? Did someone test? Just wondering as this patch here landly shortly after the uplift from comm-central to comm-aurora.
You need to log in before you can comment on or make changes to this bug.