Closed
Bug 701481
Opened 13 years ago
Closed 13 years ago
App Tabs lost with current nightly: SessionStore: The session file is invalid: TypeError: this._extractHostsForCookies is not a function
Categories
(Firefox :: Session Restore, defect)
Firefox
Session Restore
Tracking
()
RESOLVED
FIXED
Firefox 11
People
(Reporter: kdevel, Assigned: zpao)
References
Details
Attachments
(1 file)
1002 bytes,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
User Agent:
Steps to reproduce:
1. Copy a saved profile generated with Fx 9.0a1 into .mozilla.
2. Start nightly 2011-11-10-03-14-03-mozilla-central.
Actual results:
2. App Tabs are lost. Error console says “SessionStore: The session file is invalid: TypeError: this._extractHostsForCookies is not a function”
Expected results:
2. Keep App Tabs.
2011-11-09-03-11-11-mozilla-central is OK.
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6d42793c4807&tochange=c60535115ea1
Updated•13 years ago
|
Component: General → Session Restore
QA Contact: general → session.restore
Component: Session Restore → General
OS: Other → Linux
Hardware: Other → x86_64
Comment 1•13 years ago
|
||
dupe of 701171 ?
Assignee | ||
Comment 2•13 years ago
|
||
I... uhhh... oops.
Assignee: nobody → paul
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #573607 -
Flags: review?(gavin.sharp)
Comment 3•13 years ago
|
||
Comment on attachment 573607 [details] [diff] [review]
Patch v0.1
why didn't tests catch this?
Attachment #573607 -
Flags: review?(gavin.sharp) → review+
Updated•13 years ago
|
Component: General → Session Restore
OS: Linux → All
Hardware: x86_64 → All
(In reply to Paul O'Shannessy [:zpao] from comment #2)
> Created attachment 573607 [details] [diff] [review] [diff] [details] [review]
> Patch v0.1
Works.
(In reply to Gavin Sharp (use gavin@gavinsharp.com for email) from comment #3)
> why didn't tests catch this?
Can't it be checked automatically? I mean every linker complains on unresolved symbols ...
Assignee | ||
Comment 6•13 years ago
|
||
(In reply to Gavin Sharp (use gavin@gavinsharp.com for email) from comment #3)
> Comment on attachment 573607 [details] [diff] [review] [diff] [details] [review]
> Patch v0.1
>
> why didn't tests catch this?
This is now only in the startup path. And it only affects history entries where there are children entries. When I did my manual testing I used simple pages so I didn't see this. Testing with gmail, I could repro.
Ideally this would be covered by mozmill tests or at least litmus test
(In reply to Stefan from comment #4)
> Can't it be checked automatically? I mean every linker complains on
> unresolved symbols ...
This is in interpreted JS, where we don't have that sort of tool.
Comment 7•13 years ago
|
||
seems fixed in latest hourly.
Comment 8•13 years ago
|
||
nevermind... 3+ app tabs nukes it
Assignee | ||
Comment 9•13 years ago
|
||
(In reply to chaosfreedom1220 from comment #8)
> nevermind... 3+ app tabs nukes it
The fix hasn't been checked in. This bug will be marked RESOLVED FIXED when it is. As I mentioned in comment 6, not all websites will trigger the error - it has nothing to do with how many app tabs you have.
Assignee | ||
Comment 10•13 years ago
|
||
pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/23e0d7c97b34
Blocks: 698565
Whiteboard: [inbound]
Comment 11•13 years ago
|
||
Would I get my "app tabs" back tomorrow or do I start to "pin" the ones I remember of?
Assignee | ||
Comment 12•13 years ago
|
||
(In reply to alex_mayorga from comment #11)
> Would I get my "app tabs" back tomorrow or do I start to "pin" the ones I
> remember of?
The ones you lost are "lost", though you should be able to load that session tomorrow to get them back. Alternatively, turning on session restore when loading that session should restore them just fine.
For newly pinned tabs in a new session, they should be restored properly in tomorrow's nightly (assuming the above commit gets merged in before nightly builds, which it should). The error happens at startup, not during saving.
Comment 13•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 11
You need to log in
before you can comment on or make changes to this bug.
Description
•