886149 - Undefined last crash id can causes exception in delayed startup

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Browser, defect)

Description

[Jim Mathies [:jimm]]

Attachment: fix

Nothing serious since it doesn't prevent code from executing. Needs to get cleaned up though. I also added an exception trap around the crash submit code since we don't own it.

Comment 1

[Brian R. Bondy [:bbondy]]

Comment on attachment 766469 [details] [diff] [review]
fix

Review of attachment 766469 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/content/browser-ui.js
@@ +226,5 @@
> +      try {
> +        var lastCrashID = Cc["@mozilla.org/xre/app-info;1"].getService(Ci.nsIXULAppInfo).lastRunCrashID;
> +        if (lastCrashID && lastCrashID.length) {
> +          Util.dumpLn("Submitting last crash id:", lastCrashID);
> +          this.CrashSubmit.submit(lastCrashID);

nit: I'd only put this line in the try/catch

Comment 2

[Jim Mathies [:jimm]]

Will do - updated per comments -

https://hg.mozilla.org/integration/mozilla-inbound/rev/ccb5192667d0

Thanks for the quick review!

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/ccb5192667d0