Undefined last crash id can causes exception in delayed startup

RESOLVED FIXED in Firefox 24

Status

RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: jimm, Assigned: jimm)

Tracking

Trunk
Firefox 24
x86_64
Windows 8.1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 766469 [details] [diff] [review]
fix

Nothing serious since it doesn't prevent code from executing. Needs to get cleaned up though. I also added an exception trap around the crash submit code since we don't own it.
Attachment #766469 - Flags: review?(netzen)
Comment on attachment 766469 [details] [diff] [review]
fix

Review of attachment 766469 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/content/browser-ui.js
@@ +226,5 @@
> +      try {
> +        var lastCrashID = Cc["@mozilla.org/xre/app-info;1"].getService(Ci.nsIXULAppInfo).lastRunCrashID;
> +        if (lastCrashID && lastCrashID.length) {
> +          Util.dumpLn("Submitting last crash id:", lastCrashID);
> +          this.CrashSubmit.submit(lastCrashID);

nit: I'd only put this line in the try/catch
Attachment #766469 - Flags: review?(netzen) → review+
(Assignee)

Comment 2

5 years ago
Will do - updated per comments -

https://hg.mozilla.org/integration/mozilla-inbound/rev/ccb5192667d0

Thanks for the quick review!
https://hg.mozilla.org/mozilla-central/rev/ccb5192667d0
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.