Closed Bug 886239 Opened 7 years ago Closed 7 years ago

B2G RIL: Remove retryCount from MobileConnection

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: tzimmermann, Assigned: tzimmermann)

References

Details

(Whiteboard: [fixed-in-birch])

Attachments

(1 file, 2 obsolete files)

After bugs 875710 and 886238 have been, the old interface for retrieving the number of unlock retries can be removed.
(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #0)
> After bugs 875710 and 886238 have been

... fixed.
Hi Edgar,

Please review this patch. There are no users of rilcontext.retryCount left. Shall I remove this attribute as well?

Thanks!
Attachment #766582 - Flags: review?(echen)
Comment on attachment 766582 [details] [diff] [review]
[01] Bug 886239: Remove retryCount from nsIDOMMobileConnection

Review of attachment 766582 [details] [diff] [review]:
-----------------------------------------------------------------

Edgar is on his military service, and, yes, please remove rilContext.retryCount as well.
Attachment #766582 - Flags: review?(echen) → feedback+
Removed retryCount from implementation.
Attachment #766582 - Attachment is obsolete: true
Attachment #766588 - Flags: review?(vyang)
Comment on attachment 766588 [details] [diff] [review]
[01] Bug 886239: Remove retryCount from nsIDOMMobileConnection (v2)

Review of attachment 766588 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you :)
Attachment #766588 - Flags: review?(vyang) → review+
Blocks: 857414
https://hg.mozilla.org/mozilla-central/rev/ea06c8b82c7f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Component: General → RIL
Summary: Remove retryCount from MobileConnection → B2G RIL: Remove retryCount from MobileConnection
You need to log in before you can comment on or make changes to this bug.