886239 - B2G RIL: Remove retryCount from MobileConnection

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

After bugs 875710 and 886238 have been, the old interface for retrieving the number of unlock retries can be removed.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #0)
> After bugs 875710 and 886238 have been

... fixed.

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 886239: Remove retryCount from nsIDOMMobileConnection

Hi Edgar,

Please review this patch. There are no users of rilcontext.retryCount left. Shall I remove this attribute as well?

Thanks!

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 766582 [details] [diff] [review]
[01] Bug 886239: Remove retryCount from nsIDOMMobileConnection

Review of attachment 766582 [details] [diff] [review]:
-----------------------------------------------------------------

Edgar is on his military service, and, yes, please remove rilContext.retryCount as well.

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 886239: Remove retryCount from nsIDOMMobileConnection (v2)

Removed retryCount from implementation.

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 766588 [details] [diff] [review]
[01] Bug 886239: Remove retryCount from nsIDOMMobileConnection (v2)

Review of attachment 766588 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you :)

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 886239: Remove retryCount from nsIDOMMobileConnection (v3)

Rebased only.

Comment 7

[Thomas Zimmermann [:tzimmermann] [:tdz]]

https://hg.mozilla.org/projects/birch/rev/ea06c8b82c7f

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ea06c8b82c7f