886295 - Printer error pop-up when printing PDF

Status: VERIFIED FIXED

(Core :: Printing: Output, defect)

Description

[Loic]

STR:
1) Open PDF http://excerpts.numilog.com/books/2297001363.pdf
2) Print (e.g. with MS Document XPS Writer)

Result: Printer error pop-up during printing, and the print is not created locally.

Regression range:
good=2013-06-19
bad=2013-06-20
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d2a7cfa34154&tochange=8ea92aeab783

Suspected bug:
Robert O'Callahan — Bug 880854. Part 2: Support reflows/frame reconstruction in print/print-preview documents by promoting them to frame reconstruction of the whole document. r=mats

Comment 1

[bhavana bajaj [:bajaj]]

Does this happen with a lot of pdf's or a few that are specially crafted ?

Comment 2

[Loic]

(In reply to bhavana bajaj [:bajaj] from comment #1)
> Does this happen with a lot of pdf's or a few that are specially crafted ?

I dunno, I just tested this one. But there was no issue to print it until 2013-06-20.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This is quite hard to fix. I think we should just back out the fix for bug 880854. I'll explain more over there.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: backout

Comment 7

[Alice0775 White]

Automation test should be provided.

Comment 8

[Mats Palmgren (inactive)]

Comment on attachment 770021 [details] [diff] [review]
backout

Bug 880854 part 2 only changes 5 files:
http://hg.mozilla.org/mozilla-central/rev/775a172255b1

It seems there are unrelated changes in this patch.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: correct patch

I had attached the wrong patch, sorry

Comment 10

[Mats Palmgren (inactive)]

Comment on attachment 775073 [details] [diff] [review]
correct patch

r=mats

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a5aca7b49425

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 775073 [details] [diff] [review]
correct patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 880854
User impact if declined: bad failures to print under various circumstances (e.g. some pages with downloadable fonts)
Testing completed (on m-c, etc.): none. Just a backout.
Risk to taking this patch (and alternatives if risky): Low risk. Just a backout.
String or IDL/UUID changes made by this patch: none

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Bustage fix: https://hg.mozilla.org/integration/mozilla-inbound/rev/7848493ca3f0

Comment 14

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7848493ca3f0

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Needs a branch-specific patch for uplift.

Comment 16

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/615758994f36

Comment 17

[Bogdan Maris, Desktop Test Engineering]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:24.0) Gecko/20100101 Firefox/24.0
Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Firefox/24.0
Mozilla/5.0 (Windows NT 6.2; rv:24.0) Gecko/20100101 Firefox/24.0

Verified as fixed on Firefox 24 beta 6 (buildID: 20130826142034) and latest Nightly (buildID: 20130826190748).

Comment 18

[u279076]

Bogdan, please verify this is fixed in Firefox 25.

Comment 19

[Bogdan Maris, Desktop Test Engineering]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20100101 Firefox/25.0
Mozilla/5.0 (X11; Linux i686; rv:25.0) Gecko/20100101 Firefox/25.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:25.0) Gecko/20100101 Firefox/25.0

Also verified as fixed on latest Aurora 25.0a2 (buildID: 20130910004002).