Closed Bug 886300 Opened 13 years ago Closed 13 years ago

Intermittent social/browser_blocklist.js | no new providers left enabled - Got 0, expected 1

Categories

(Firefox Graveyard :: SocialAPI, defect)

Product:
Firefox Graveyard
Component:
SocialAPI
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox24 fixed, firefox25 fixed, firefox26 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 26
Tracking Flags:
Tracking Status
firefox24 --- fixed
firefox25 --- fixed
firefox26 --- fixed

People

(Reporter: emorley, Assigned: mixedpuppy)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

fix intermittent failure
5.89 KB, patch
mixedpuppy
: review+
Details | Diff | Splinter Review
Windows 7 32-bit mozilla-inbound debug test mochitest-browser-chrome on 2013-06-24 05:08:48 PDT for push d53ba2cc5337 slave: t-w732-ix-027 https://tbpl.mozilla.org/php/getParsedLog.php?id=24513530&tree=Mozilla-Inbound { 05:21:13 INFO - TEST-START | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js 05:21:13 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | no new providers left enabled 05:21:13 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | sub-test testSimpleBlocklist starting 05:21:13 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | blocking 'blocked' 05:21:13 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | not blocking 'good' 05:21:13 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | blocklist cleared 05:21:13 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | sub-test testSimpleBlocklist complete 05:21:13 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | no new providers left enabled 05:21:13 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | sub-test testAddingNonBlockedProvider starting 05:21:13 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | added and removed provider 05:21:13 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | adding non-blocked provider ok 05:21:14 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | sub-test testAddingNonBlockedProvider complete 05:21:14 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | no new providers left enabled 05:21:14 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | sub-test testAddingBlockedProvider starting 05:21:14 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | Unable to add blocklisted provider 05:21:14 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | sub-test testAddingBlockedProvider complete 05:21:14 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | no new providers left enabled - Got 0, expected 1 05:21:14 INFO - Stack trace: 05:21:14 INFO - JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 536 05:21:14 INFO - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/social/head.js :: <TOP_LEVEL> :: line 177 05:21:14 INFO - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/social/head.js :: <TOP_LEVEL> :: line 154 05:21:14 INFO - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/social/head.js :: <TOP_LEVEL> :: line 176 05:21:14 INFO - JS frame :: chrome://mochikit/content/browser-test.js :: testScope/test_executeSoon/<.run :: line 565 05:21:14 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 05:21:14 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | sub-test testInstallingBlockedProvider starting 05:21:14 INFO - ++DOCSHELL 2129A338 == 22 [id = 776] 05:21:14 INFO - ++DOMWINDOW == 64 (199B10F8) [serial = 2141] [outer = 00000000] 05:21:14 INFO - ++DOMWINDOW == 65 (199AD738) [serial = 2142] [outer = 199B10F8] 05:21:14 INFO - WARNING: NS_ENSURE_TRUE(mMutable) failed: file e:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/netwerk/base/src/nsSimpleURI.cpp, line 265 05:21:14 INFO - WARNING: NS_ENSURE_TRUE(mMutable) failed: file e:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/netwerk/base/src/nsSimpleURI.cpp, line 265 05:21:14 INFO - ++DOMWINDOW == 66 (21C02B80) [serial = 2143] [outer = 199B10F8] 05:21:14 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "https://test1.example.com/browser/browser/base/content/test/social/social_activate.html" line: 0}] 05:21:15 INFO - WARNING: NS_ENSURE_TRUE(mMutable) failed: file e:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/netwerk/base/src/nsSimpleURI.cpp, line 265 05:21:15 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | Unable to add blocklisted provider 05:21:15 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | sub-test testInstallingBlockedProvider complete 05:21:15 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | no new providers left enabled - Got 0, expected 1 05:21:15 INFO - Stack trace: 05:21:15 INFO - JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 536 05:21:15 INFO - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/social/head.js :: <TOP_LEVEL> :: line 177 05:21:15 INFO - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/social/head.js :: <TOP_LEVEL> :: line 154 05:21:15 INFO - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/social/head.js :: <TOP_LEVEL> :: line 176 05:21:15 INFO - JS frame :: chrome://mochikit/content/browser-test.js :: testScope/test_executeSoon/<.run :: line 565 05:21:15 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 05:21:15 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | sub-test testBlockingExistingProvider starting 05:21:15 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | sub-test testBlockingExistingProvider failed: Error: SocialService.addProvider: provider with this origin already exists 05:21:15 INFO - addProvider@resource://gre/modules/SocialService.jsm:399 05:21:15 INFO - tests.testBlockingExistingProvider@chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js:132 05:21:15 INFO - @chrome://mochitests/content/browser/browser/base/content/test/social/head.js:180 05:21:15 INFO - @chrome://mochitests/content/browser/browser/base/content/test/social/head.js:154 05:21:15 INFO - @chrome://mochitests/content/browser/browser/base/content/test/social/head.js:176 05:21:15 INFO - testScope/test_executeSoon/<.run@chrome://mochikit/content/browser-test.js:565 05:21:15 INFO - Stack trace: 05:21:15 INFO - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/social/head.js :: <TOP_LEVEL> :: line 182 05:21:15 INFO - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/social/head.js :: <TOP_LEVEL> :: line 154 05:21:15 INFO - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/social/head.js :: <TOP_LEVEL> :: line 176 05:21:15 INFO - JS frame :: chrome://mochikit/content/browser-test.js :: testScope/test_executeSoon/<.run :: line 565 05:21:15 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 05:21:15 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | sub-test testBlockingExistingProvider complete 05:21:16 INFO - INFO TEST-END | chrome://mochitests/content/browser/browser/base/content/test/social/browser_blocklist.js | finished in 2976ms ... <followed by a load more> }
Attached patch fix intermittent failure (obsolete) — — Splinter Review
https://tbpl.mozilla.org/?tree=Try&rev=dd96f96b0708 The change in browser_addons.js is the actual fix. The other changes will provide a little more log file clarity in failure cases.
Assignee: nobody → mixedpuppy
Attachment #766806 - Flags: review?(mhammond)
Blocks: 847124
Comment on attachment 766806 [details] [diff] [review] fix intermittent failure Review of attachment 766806 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/base/content/test/social/browser_blocklist.js @@ +60,5 @@ > ok(true, "added and removed provider"); > finish(true); > }); > + } catch(e) { > + ok(false, "SocialService.removeProvider threw exception" + e); need at least a space at the end of the string (I'd end the string with ": ") @@ +65,4 @@ > finish(false); > } > }); > } catch(e) { probably want an ok(false, ...); here like there is above?
Attachment #766806 - Flags: review?(mhammond) → review+
Thank you for looking at this so quickly :-)
Attached patch fix intermittent failure — — Splinter Review
feedback added. https://hg.mozilla.org/integration/mozilla-inbound/rev/c6e4936118ca
Attachment #766806 - Attachment is obsolete: true
Attachment #767186 - Flags: review+
Blocks: 850721
https://hg.mozilla.org/mozilla-central/rev/c6e4936118ca
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #767186 - Attachment is patch: true
Attachment #767186 - Attachment mime type: text/x-patch → text/plain
Shane, any other ideas on this bug?
Flags: needinfo?(mixedpuppy)
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #14) > Shane, any other ideas on this bug? heh, funny, I've been looking at this for a couple hours now. new great ideas yet.
Flags: needinfo?(mixedpuppy)
Going to optimistically call this fixed by bug 847124.
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
status-firefox24: --- → fixed
status-firefox25: --- → fixed
status-firefox26: --- → fixed
Resolution: --- → FIXED
Target Milestone: Firefox 25 → Firefox 26
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: