886423 - Flip the click_to_play UI on by default (Firefox desktop)

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Benjamin Smedberg]

Now that the new plugin doorhanger has landed, flip plugins.click_to_play on by default.

Comment 1

[Benjamin Smedberg]

Attachment: Turn on the click-to-play UI by default in Firefox desktop. As a side effect, remove the plugin permission from about:permissions because we're using per-plugin permission not per-site and about:permissions doesn't know about that. Page Info knows about i

Comment 2

[Dana Keeler (she/her) [:keeler]]

Comment on attachment 766799 [details] [diff] [review]
Turn on the click-to-play UI by default in Firefox desktop. As a side effect, remove the plugin permission from about:permissions because we're using per-plugin permission not per-site and about:permissions doesn't know about that. Page Info knows about i

Review of attachment 766799 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome!
Is the plan to just not support plugin management in about:permissions? (I seems a little odd that Page Info can handle it but about:permissions can't. That said, it's completely broken right now, so removing it for now is not a bad way to go.)

Comment 3

[Dana Keeler (she/her) [:keeler]]

If we decide that about:permissions won't ever handle plugins again, we can WONTFIX bug 775857.

Comment 4

[Benjamin Smedberg]

For now, I was told to remove the nonfunctional UI in about:permissions. I don't think that is a final decision about whether we want it or not, so I'll leave bug 775857 alone for now.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e28ceb0c4a16

Comment 6

[Paul Silaghi, QA [:pauly]]

plugins.click_to_play=true by default
about:permissions/plugins is gone
Verified fixed FF 25.0a1 (2013-06-26) Win 7, Mac OS X 10.8.3, Ubuntu 13.04