Closed
Bug 886508
Opened 11 years ago
Closed 11 years ago
Swiped words not appearing when using Google Keyboard
Categories
(Firefox for Android Graveyard :: Keyboards and IME, defect)
Tracking
(firefox22 affected, firefox23 affected, firefox24 affected, firefox25 verified, fennec+)
VERIFIED
FIXED
Firefox 25
People
(Reporter: bnicholson, Assigned: jchen)
References
Details
Attachments
(1 file)
1.93 KB,
patch
|
cpeterson
:
review+
|
Details | Diff | Splinter Review |
STR: 1) Open AwesomeScreen 2) Swipe "Firefox" 3) Swipe "beta" The "beta" I swipe does not appear in the URL bar, and only a space is entered. In other words, instead of seeing "Firefox beta", I only see "Firefox ". This is on a Droid RAZR (4.1.2) with Google Keyboard from the Play Store. Not sure if this is a phone-specific issue or an issue with the Google Keyboard app.
Updated•11 years ago
|
Assignee: nobody → nchen
tracking-fennec: ? → +
Assignee | ||
Comment 2•11 years ago
|
||
When swiping a word, the Google keyboard first commits a space, then it sets the composition string to the new word. The problem is, we reset the keyboard after the space to switch to search mode, but because of the reset, the composition string is never set. This patch delays resetting the keyboard to after setting the composition string, by ignoring the space, and (when using gesture keyboards) allowing resetting the keyboard even if there is a composition string.
Attachment #776447 -
Flags: review?(cpeterson)
Comment 3•11 years ago
|
||
Comment on attachment 776447 [details] [diff] [review] Work around Google gesture keyboard quirk (v1) Review of attachment 776447 [details] [diff] [review]: ----------------------------------------------------------------- Have you tested this with other gesture keyboards, like Swype or SwiftKey?
Assignee | ||
Comment 4•11 years ago
|
||
(In reply to Chris Peterson (:cpeterson) from comment #3) > Comment on attachment 776447 [details] [diff] [review] > Work around Google gesture keyboard quirk (v1) > > Review of attachment 776447 [details] [diff] [review]: > ----------------------------------------------------------------- > > Have you tested this with other gesture keyboards, like Swype or SwiftKey? Yes
Status: NEW → ASSIGNED
Comment 5•11 years ago
|
||
Comment on attachment 776447 [details] [diff] [review] Work around Google gesture keyboard quirk (v1) Review of attachment 776447 [details] [diff] [review]: ----------------------------------------------------------------- Just making sure. (I use Swype.) ;) LGTM!
Attachment #776447 -
Flags: review?(cpeterson) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 6•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d428ab19f2c7
Keywords: checkin-needed
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d428ab19f2c7
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•