886533 - fix compare.py --pgo to work

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

on the ux branch, specifying nonpgo.name = 'ux-non-pgo', yields a branch_map id error.  This was introduced while adding xperf support.

Also add some docs for the pgo stuff.

Comment 1

[Matthew N. [:MattN]]

Attachment: v.1 Pass the pgo option to compareResults

I haven't tested any of my recent patches with datazilla because it doesn't seem to be working (even on the web interface for m-c).

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 772997 [details] [diff] [review]
v.1 Pass the pgo option to compareResults

Note that this patch applies on top of bug 891643

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 772997 [details] [diff] [review]
v.1 Pass the pgo option to compareResults

Review of attachment 772997 [details] [diff] [review]:
-----------------------------------------------------------------

I had to rack my brains on this for a while, but it looks quite simple as you have demonstrated.  I am fine ignoring the datazilla aspect of this, that is a work in progress which is not 100% ready for digestion.

Comment 4

[Matthew N. [:MattN]]

Thanks for the speedy reviews!
http://hg.mozilla.org/build/talos/rev/e1673bbd8ef8