fix compare.py --pgo to work

RESOLVED FIXED

Status

Testing
Talos
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jmaher, Assigned: MattN)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
on the ux branch, specifying nonpgo.name = 'ux-non-pgo', yields a branch_map id error.  This was introduced while adding xperf support.

Also add some docs for the pgo stuff.
Created attachment 772997 [details] [diff] [review]
v.1 Pass the pgo option to compareResults

I haven't tested any of my recent patches with datazilla because it doesn't seem to be working (even on the web interface for m-c).
Assignee: nobody → mnoorenberghe+bmo
Status: NEW → ASSIGNED
Attachment #772997 - Flags: review?(jmaher)
Comment on attachment 772997 [details] [diff] [review]
v.1 Pass the pgo option to compareResults

Note that this patch applies on top of bug 891643
(Reporter)

Comment 3

5 years ago
Comment on attachment 772997 [details] [diff] [review]
v.1 Pass the pgo option to compareResults

Review of attachment 772997 [details] [diff] [review]:
-----------------------------------------------------------------

I had to rack my brains on this for a while, but it looks quite simple as you have demonstrated.  I am fine ignoring the datazilla aspect of this, that is a work in progress which is not 100% ready for digestion.
Attachment #772997 - Flags: review?(jmaher) → review+
Thanks for the speedy reviews!
http://hg.mozilla.org/build/talos/rev/e1673bbd8ef8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.