88673 - :" should be removed from "Pages in history expires after:

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Henrik Gemal]

To be consistent with both the prefs in:
Pref -> Privacy -> Master Password
and
Pref -> Mail -> Addrinsing

We need to change Pref -> Navigator -> History
Pages in history expires after: [ ] days.
to
Pages in history expires after [ ] days

thats removing the ":" and the "."

build 20010630

Comment 1

[Radha on family leave (not reading bugmail)]

You may want to run this thro' a UI person. I do not own this. Giving to browser
team.

Comment 2

[timeless]

.

Comment 3

[sairuh (rarely reading bugmail)]

hmm...samir isn't gonna get to this any time soon...lessee...blake? bueller? ;)

triage as needed.

Comment 4

[Blake Ross]

usability/polish, 0.9.4.

Comment 5

[Bradley Hart]

I have a patch to fix this, anyone mind if I take this bug?

Comment 6

[Bradley Hart]

Attachment: patch which removes the ":" and the "."

Comment 7

[Bradley Hart]

Reassign to me.

Comment 8

[timeless]

r=timeless

Comment 9

[Scott Collins]

To me, it looks like the period is needed.  It's a complete sentence, starting
with a capital letter, containing a subject, verb, object, the works.  If this
is for consistency, well, OK, but I'd like to have a UE person weigh in with an
r= to make sure.  Someone like German, mpt, or Ben Goodger.  Once you have that,
sr=scc.

Comment 10

[Matthew T (active 1999-2002)]

Labels for controls may indeed take the form of a complete sentence, but 
whether or not they do, they should never end in a full stop. (Here's some QA 
fodder: Any <label> in Mozilla which ends in a full stop is a bug. Either the 
full stop should be removed, or it's meant to be a <description> instead.)

So, this patch is a definite improvement and should be checked in. If, however, 
Bradley would like to make it even better, it would be worth removing the 
potentially confusing reference to `expiring':
|
| Remember which pages I visited in the last [  9] days
|
Note that this would require changing the accesskey as well, so if you want to 
leave it for a separate bug that's fine.

Comment 11

[Bradley Hart]

Attachment: patch which changes the statement, as well as the access key

Comment 12

[Bradley Hart]

Attachment: argh, I messed up the statement in that last patch. Sorry for the spam, and please ignore my previous patch.

Comment 13

[Bradley Hart]

needing r= and sr= for new patch...

Comment 14

[timeless]

So 'I' is ok in dialogs? [And 'my' is not?]

Comment 15

[Jatin Billimoria]

Suggested wordings:

"History is a list of previously visited pages.">

"Remember visited pages for the last X days"

Comment 16

[Bradley Hart]

Attachment: Patch with jatin's wording

Comment 17

[timeless]

r=timeless

Comment 18

[[e-mail] (gone - use [e-mail] instead)]

Fix checked in.

Comment 19

[sairuh (rarely reading bugmail)]

vrfy fixed, based on bradley's 08/20/01 18:43 patch.

linux, 2001.08.22.08-comm
winnt, 2001.08.22.09-comm
mac 9.1, 2001.08.22.08-comm