Closed
Bug 88476
Opened 23 years ago
Closed 23 years ago
bhart00@yahoo.com would like CVS commit access
Categories
(mozilla.org :: Repository Account Requests, task)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhart, Assigned: marcia)
References
Details
I would like CVS commit access to make simple wording changes, and maybe some small XUL and/or Javascript changes. I have fixed bugs 75819, 86681, 87028, 81406 and 85993. I have printed the form and will fax it soon.
Reporter | ||
Comment 1•23 years ago
|
||
I have faxed the form. Do I still need to mail it in?
Assignee | ||
Comment 2•23 years ago
|
||
form received. Yes, I would prefer to have the original signed form on file here. I assume from your request that you are seeking write access, so you will have to get a voucher as well as 3 SRs in order to be granted access.
Status: NEW → ASSIGNED
Comment 3•23 years ago
|
||
just to turn these into easy links, see bug #75819, bug #86681, bug #87028, bug #81406, and bug #85993
Comment 4•23 years ago
|
||
Well, BHart does good work, but I believe our current policy is that once CVS write access is given, it applies to pretty much the whole tree (with a couple of mechanically enforced exceptions), so ensuring that he would only keep to 'simple wording changes, and maybe some small XUL and/or Javascript changes' must be on his head and that of his vouchers. Is this how we've handled such cases in the past? I think this needs a little group discussion among the policy makers (sr council, for this purpose, I think).
Reporter | ||
Comment 5•23 years ago
|
||
CVS access was granted to stephend@netscape.com, who was/is making these same type of changes. Bug 69429 deals with this.
Comment 6•23 years ago
|
||
Alright, I can vouch for you on this basis. This explicitly makes me liable for any checkins you make outside this initial scope, so please don't abuse my trust :-) sr=scc for BHart to have CVS write access for wording changes, and maybe some small XUL and/or Javascript changes. As you broaden your skills, you and I together, probably with some other sr's, can decide when to broaden your checkin activities to match.
Assignee | ||
Comment 7•23 years ago
|
||
Brad - okay, you have sr=scc, with the stipulations noted. You will still need to have 2 other SRs take a look at your code before I can flip the switch. Go to http://mozilla.org/hacking/reviewers.html to see the complete list of current SRs.
Comment 8•23 years ago
|
||
I share scc's concerns, so provided BHart keeps to simple non-C++ changes, sr=darin.
Comment 9•23 years ago
|
||
I suggest marking this invalid. I know access has been given in the past to people who don't meet all the requirements, but that won't scale going forward. bhart, I'm sorry you've been the first person to get put through the sr= wringer. If bhart becomes a patch machine, or meets the criteria, we can re-open. bhart, as I've offered in email, I'll help you land mozilla/mailnews patches.
Reporter | ||
Comment 10•23 years ago
|
||
Marking invalid per comments from Brendan and other SRs.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → INVALID
Reporter | ||
Comment 11•23 years ago
|
||
Reopening bug per e-mail comments from Brendan. Do my previous SRs still apply?
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Comment 12•23 years ago
|
||
bradley, can you make this bug depend on all the bugs you've fixed? I know you've fixed some more since we marked this invalid.
Reporter | ||
Comment 13•23 years ago
|
||
All bugs I've fixed are now marked as depends.
Comment 14•23 years ago
|
||
I've seen enough good work that helped the project, and I don't think bhart is gonna get drunk, stay up late, and write too much C++ (like others no longer with us who are responsible for some of our object oriented pile o' code have done), so I'm happy to sr=brendan@mozilla.org his cvs access so he can keep helping with lower overhead. /be
Status: REOPENED → ASSIGNED
Comment 15•23 years ago
|
||
(I was kidding about the drunk part... too much code in the pile was written while completely sober, if you can believe it!) /be
Reporter | ||
Comment 16•23 years ago
|
||
Does that give me all the SRs I need?
Comment 17•23 years ago
|
||
darin, seth please stamp your sr='s and marcia will activate. /be
Comment 18•23 years ago
|
||
following brendan's lead, sr=sspitzer bhart has kept the patches coming, and he understands the process. I think we should update http://mozilla.org/hacking/reviewers.html to cover CVS access for those who don't do any C++ hacking.
Assignee | ||
Comment 19•23 years ago
|
||
account activated.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•