886757 - We need to load the operator size limit for MMS from the apn.json file

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Corey Frang [:gnarf]]

We should to allow the operators to define the limit for their MCC/MNC combo inside our apn.json file.  This ties in with the SMS app code landed with bug 840061.

Comment 1

[Corey Frang [:gnarf]]

Attachment: Loads the setting for MMS from apn.json

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

Right now we have no such data in the apn.json database. I guess you are aware of that and someone could provide you the values to be added to the operator_variant.xml database.

Comment 3

[Corey Frang [:gnarf]]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #2)
> Right now we have no such data in the apn.json database. I guess you are
> aware of that and someone could provide you the values to be added to the
> operator_variant.xml database.

Yes, this is just to support being able to add this key to apn.json - We dicussed this during a meeting at the work week in taipei.

Comment 4

[Corey Frang [:gnarf]]

Going to wait for Beatriz to give me some information for APN's from TEF - Perhaps we could get some information for the size limit based on MCC/MNC from LG as well?

Comment 5

[Beatriz Rodríguez [:brg]]

Email sent with enclosed information about the values in some countries according to mcc/mnc values.

Comment 6

[Fabien Cazenave [:kaze]]

Comment on attachment 767132 [details]
Loads the setting for MMS from apn.json

>-        'ril.cellbroadcast.searchlist': 'cellBroadcastSearchList'
>+        'ril.cellbroadcast.searchlist': 'cellBroadcastSearchList',
>+        'dom.mms.operatorSizeLimitation': 'operatorSizeLimitation'

I’m not sure to follow you: operatorSizeLimitation is not defined in `shared/resources/apn.json' yet, is it?

>+          // default to 300k
>+          case 'operatorSizeLimitation':
>+            item[key] = apn[name] || 300 * 1024;
>+            break;

Nitpick: let’s define the default value (300*1024) in a constant along with AUTH_TYPES, please.

Comment 7

[Fabien Cazenave [:kaze]]

I just realized that Beatriz sent you the data *after* you wrote this patch. Can you integrate this data into operator_variant.xml, please?

Comment 8

[Corey Frang [:gnarf]]

Attachment: patch v2

* Loading operatorSizeLimitation from apn.json on startup
* Tweak apn.json creator to load setting from operator_variant.xml
* Add values from TEF for operator_variant.xml

Comment 9

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 768152 [details] [diff] [review]
patch v2

Review of attachment 768152 [details] [diff] [review]:
-----------------------------------------------------------------

::: shared/resources/apn/query.js
@@ +147,5 @@
> +            var operatorSizeLimitation =
> +              otherSettings['operatorSizeLimitation'];
> +            if (operatorSizeLimitation) {
> +              operatorVariantSettings.operatorSizeLimitation =
> +                +operatorSizeLimitation;

s/+operatorSizeLimitation/operatorSizeLimitation

Comment 10

[Corey Frang [:gnarf]]

The plus is there to force it to be a number instead of a string.

Comment 11

[Corey Frang [:gnarf]]

I mean, maybe I should move that cast up a couple lines to where the var is set, but I want to ensure this value is numeric

Comment 12

[Corey Frang [:gnarf]]

master: https://github.com/mozilla-b2g/gaia/commit/151a1a160d22236a4664440c2f504364ec4a8891
v1-train: https://github.com/mozilla-b2g/gaia/commit/fa3d64fad6f3b69be17ebbfdf4b406108afc99f4

Comment 13

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: fa3d64fad6f3b69be17ebbfdf4b406108afc99f4