Closed Bug 886757 Opened 7 years ago Closed 7 years ago

We need to load the operator size limit for MMS from the apn.json file

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
All
defect
Not set
blocker

Tracking

(blocking-b2g:leo+, b2g18 fixed, b2g-v1.1hd fixed)

RESOLVED FIXED
1.1 QE3 (26jun)
blocking-b2g leo+
Tracking Status
b2g18 --- fixed
b2g-v1.1hd --- fixed

People

(Reporter: gnarf, Assigned: gnarf)

References

Details

Attachments

(1 file, 1 obsolete file)

We should to allow the operators to define the limit for their MCC/MNC combo inside our apn.json file.  This ties in with the SMS app code landed with bug 840061.
Attachment #767132 - Flags: review?(kaze)
blocking-b2g: --- → leo?
Right now we have no such data in the apn.json database. I guess you are aware of that and someone could provide you the values to be added to the operator_variant.xml database.
(In reply to José Antonio Olivera Ortega [:jaoo] from comment #2)
> Right now we have no such data in the apn.json database. I guess you are
> aware of that and someone could provide you the values to be added to the
> operator_variant.xml database.

Yes, this is just to support being able to add this key to apn.json - We dicussed this during a meeting at the work week in taipei.
Blocks: 881648
blocking-b2g: leo? → leo+
Going to wait for Beatriz to give me some information for APN's from TEF - Perhaps we could get some information for the size limit based on MCC/MNC from LG as well?
Flags: needinfo?(veeresh.maka)
Flags: needinfo?(brg)
Email sent with enclosed information about the values in some countries according to mcc/mnc values.
Flags: needinfo?(brg)
Comment on attachment 767132 [details]
Loads the setting for MMS from apn.json

>-        'ril.cellbroadcast.searchlist': 'cellBroadcastSearchList'
>+        'ril.cellbroadcast.searchlist': 'cellBroadcastSearchList',
>+        'dom.mms.operatorSizeLimitation': 'operatorSizeLimitation'

I’m not sure to follow you: operatorSizeLimitation is not defined in `shared/resources/apn.json' yet, is it?

>+          // default to 300k
>+          case 'operatorSizeLimitation':
>+            item[key] = apn[name] || 300 * 1024;
>+            break;

Nitpick: let’s define the default value (300*1024) in a constant along with AUTH_TYPES, please.
I just realized that Beatriz sent you the data *after* you wrote this patch. Can you integrate this data into operator_variant.xml, please?
Attached patch patch v2Splinter Review
* Loading operatorSizeLimitation from apn.json on startup
* Tweak apn.json creator to load setting from operator_variant.xml
* Add values from TEF for operator_variant.xml
Attachment #767132 - Attachment is obsolete: true
Attachment #767132 - Flags: review?(kaze)
Attachment #768152 - Flags: review?(kaze)
Comment on attachment 768152 [details] [diff] [review]
patch v2

Review of attachment 768152 [details] [diff] [review]:
-----------------------------------------------------------------

::: shared/resources/apn/query.js
@@ +147,5 @@
> +            var operatorSizeLimitation =
> +              otherSettings['operatorSizeLimitation'];
> +            if (operatorSizeLimitation) {
> +              operatorVariantSettings.operatorSizeLimitation =
> +                +operatorSizeLimitation;

s/+operatorSizeLimitation/operatorSizeLimitation
The plus is there to force it to be a number instead of a string.
I mean, maybe I should move that cast up a couple lines to where the var is set, but I want to ensure this value is numeric
Attachment #768152 - Flags: review?(kaze) → review+
v1.1.0hd: fa3d64fad6f3b69be17ebbfdf4b406108afc99f4
Flags: needinfo?(veeresh.maka)
You need to log in before you can comment on or make changes to this bug.