Port GTK2 to GTK3 - gtk entry fixes

RESOLVED FIXED in mozilla25

Status

()

Core
Widget: Gtk
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: stransky, Assigned: stransky)

Tracking

Trunk
mozilla25
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
+++ This bug was initially created as a clone of Bug #627699 +++

GTK+ 3.0 and GNOME 3 are approaching and we should get Firefox ready for them. This bug is for gtk entry fixes - it has wrong size (too small) and wrong input text color.
(Assignee)

Comment 1

5 years ago
Created attachment 767685 [details] [diff] [review]
entry size fix - WIP

Just for the record.
(Assignee)

Comment 2

5 years ago
The fix above does not work on gtk entries on web pages. Those are rendered as "width=2,height=19" and are too small then.
(Assignee)

Comment 3

5 years ago
Created attachment 770784 [details] [diff] [review]
patch

Gtk3 doc advises to use border+padding for gtk_entry size which actually works fine and gives the same result as gtk_entry rendered by gtk3 native apps. I tested that on terminal preferences dialog and the results are identical.
Attachment #767685 - Attachment is obsolete: true
Attachment #770784 - Flags: review?(karlt)
(Assignee)

Updated

5 years ago
Whiteboard: [check linux try build before requesting checkin]
Can you point me at the doc, please?
(Assignee)

Comment 6

5 years ago
IMHO border+padding is a space between text and entry frame, regards to the doc.
Comment on attachment 770784 [details] [diff] [review]
patch

This looks right for GtkEntry at least.

I suspect this code should probably be in the fall-through case at the end of this function, so other widgets also get their padding recognised.
Attachment #770784 - Flags: review?(karlt) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/662cc22140e5
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25

Updated

4 years ago
Blocks: 1034064

Updated

4 years ago
No longer blocks: 1034064
You need to log in before you can comment on or make changes to this bug.