+++ This bug was initially created as a clone of Bug #627699 +++ GTK+ 3.0 and GNOME 3 are approaching and we should get Firefox ready for them. This bug is for gtk entry fixes - it has wrong size (too small) and wrong input text color.
The fix above does not work on gtk entries on web pages. Those are rendered as "width=2,height=19" and are too small then.
Created attachment 770784 [details] [diff] [review] patch Gtk3 doc advises to use border+padding for gtk_entry size which actually works fine and gives the same result as gtk_entry rendered by gtk3 native apps. I tested that on terminal preferences dialog and the results are identical.
Whiteboard: [check linux try build before requesting checkin]
Can you point me at the doc, please?
IMHO border+padding is a space between text and entry frame, regards to the doc.
Comment on attachment 770784 [details] [diff] [review] patch This looks right for GtkEntry at least. I suspect this code should probably be in the fall-through case at the end of this function, so other widgets also get their padding recognised.
Attachment #770784 - Flags: review?(karlt) → review+
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.