Closed Bug 886771 Opened 11 years ago Closed 11 years ago

Port GTK2 to GTK3 - gtk entry fixes

Categories

(Core :: Widget: Gtk, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: stransky, Assigned: stransky)

References

Details

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #627699 +++

GTK+ 3.0 and GNOME 3 are approaching and we should get Firefox ready for them. This bug is for gtk entry fixes - it has wrong size (too small) and wrong input text color.
Attached patch entry size fix - WIP (obsolete) — Splinter Review
Just for the record.
The fix above does not work on gtk entries on web pages. Those are rendered as "width=2,height=19" and are too small then.
Attached patch patchSplinter Review
Gtk3 doc advises to use border+padding for gtk_entry size which actually works fine and gives the same result as gtk_entry rendered by gtk3 native apps. I tested that on terminal preferences dialog and the results are identical.
Attachment #767685 - Attachment is obsolete: true
Attachment #770784 - Flags: review?(karlt)
Whiteboard: [check linux try build before requesting checkin]
Can you point me at the doc, please?
IMHO border+padding is a space between text and entry frame, regards to the doc.
Comment on attachment 770784 [details] [diff] [review]
patch

This looks right for GtkEntry at least.

I suspect this code should probably be in the fall-through case at the end of this function, so other widgets also get their padding recognised.
Attachment #770784 - Flags: review?(karlt) → review+
https://hg.mozilla.org/mozilla-central/rev/662cc22140e5
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Blocks: 1034064
No longer blocks: 1034064
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: