886911 - GC: generational GC does not need to terminate off-main-thread compilation

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

This should be a tremendous and easy perf win.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Patch

As discussed on IRC.

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 767796 [details] [diff] [review]
Patch

Review of attachment 767796 [details] [diff] [review]:
-----------------------------------------------------------------

\o/  Excellent!

r=me

::: js/src/gc/StoreBuffer.h
@@ -216,5 @@
>              if (!pos)
>                  return;
>  
>              /* Check for overflow. */
> -            if (top - pos < (unsigned)(sizeof(unsigned) + sizeof(T))) {

Huh, I thought I fixed this at some point. I guess that patch never landed. In any case, thanks for the spot-fix!

::: js/src/ion/Ion.cpp
@@ +378,5 @@
>  {
> +    // Cancel any active or pending off thread compilations. Note that the
> +    // MIR graph does not hold any nursery pointers, so there's no need to
> +    // do this for minor GCs.
> +    JS_ASSERT(!trc->runtime->isHeapMinorCollecting());

Nice!

Comment 3

[Jan de Mooij [:jandem]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1060593e6796

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1060593e6796