886969 - Fennec allows scrolling of pages with overflow:hidden on the body element

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Test case

If there is a page with overflow:hidden set on the body, it shouldn't be scrollable.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

For reference I like the behaviour we now have on B2G, where we allow panning/zooming on the initially-visible area for documents with overflow:hidden on the root. If we switch Fennec to APZ we should be able to get this behaviour mostly for free, but if that gets delayed we could modify the JPZC code to behave that way too.

Comment 2

[Andy Mercer]

This bug prevents creating a proper slideout side menu. When the menu is out, the body shouldn't be scrollable, but at this point on FF there's no way to prevent it.

Comment 3

[BM]

It would be great to see this bug fixed given how long it's been open. Otherwise, it's impossible to scroll inside an overlay.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

If this needs to be fixed sooner than switching Fennec to C++ APZ, it shouldn't be too hard. Whoever does triage can let us know.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Our goal is to get on C++ APZC within the next

Comment 6

[Andy Mercer]

So we're looking at next September?

Comment 7

[Matthew Pollard]

Has anyone found a fix for this? It doesn't look very good. Please share it if you have, I would really appreciate it!

Comment 8

[Mike Kascel]

It looks like this isn't isolated to just the body element, it looks like overflow on a particular axis isn't respected on an element inside body either.  For instance, overflow-y: hidden appears to not work correctly, see this Pen: http://codepen.io/mkascel/pen/XbRbvK

Comment 11

[Dave Lozier]

I'm not sure this workaround will work for other implementations but or me it does work with Bootstrap 3 off canvas. (left hand, haven't tried right)

if (navigator.userAgent.match(/Android/i) && navigator.userAgent.match(/Firefox/i)) {
//$('body').css('overflow','hidden');/* jQuery */
document.getElementsByTagName('body')[0].style='overflow:hidden';/* vanilla */
}

I can still scroll vertically on mobile while the horizontal overflow is hidden.

Comment 12

[Kartikaya Gupta (email:[e-mail])]

This is fixed in Fennec nightly with the switch to APZ. Marking this dependent on APZ riding the trains on Fennec, so that we close this with the right target milestone when it rides.

Comment 13

[James Willcox (:snorp) ([e-mail]) (he/him)]

Resolved with the APZ stuff

Comment 14

[Andy Mercer]

Just tested this before and after updating to 48 on Android, and confirmed the problem has been fixed.

Comment 15

[Kartikaya Gupta (email:[e-mail])]

Great, thanks for checking!