887020 - Cleanup BrowserToolbar

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Sriram Ramasubramanian [:sriram]]

Currently there are just 2 browser_toolbar.xml's. They are <include> in gecko_app.xml and the views are found in BrowserToolbar.from(). Also, we don't re-inflate BrowserToolbar anymore. We can make BrowserToolbar the layout instead of it having an mLayout internally. (Oh! We had this in October 2011).

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Pass 1: Remove mLayout

First pass of BrowserToolbar cleanup.
This removes BrowserToolbarLayout and moved the code to BrowserToolbar. BrowserToolbar is created directly by inflating from XML. Hence it's findViewById() happen automagically and it doesnt need a mLayout anymore.

I'm still looking into moving findViewById()'s to onAttachedToWindow() as I've moved the listeners. I just want to find a remote case where we get a message from Gecko and we haven't initialized mBack yet, that could cause an NPE. If I'm sure that we won't run into that, I'll post a patch to move the findViewById() to onAttachedToWindow(). Until then this patch works fine (and just the same as what's there now).

Comment 2

[Sriram Ramasubramanian [:sriram]]

Thinking aloud:
The app takes ~700ms to display. The time between inflation and attaching to window is very very less, that our Gecko wouldn't be ready to give messages. It's safe to move all the findViewByIds() to onAttachedToWindow(). I'll move them.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Sriram Ramasubramanian [:sriram] from comment #2)
> Thinking aloud:
> The app takes ~700ms to display. The time between inflation and attaching to
> window is very very less, that our Gecko wouldn't be ready to give messages.
> It's safe to move all the findViewByIds() to onAttachedToWindow(). I'll move
> them.

Don't count on Gecko always loading slowly.

Comment 4

[Sriram Ramasubramanian [:sriram]]

Trying: https://tbpl.mozilla.org/?tree=Try&rev=2343831665a8

Comment 5

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cc5850cf4042

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/cc5850cf4042