Closed
Bug 887045
Opened 12 years ago
Closed 12 years ago
Private windows opened after normal windows appear in recently closed window list
Categories
(SeaMonkey :: Session Restore, defect)
SeaMonkey
Session Restore
Tracking
(seamonkey2.19 wontfix, seamonkey2.20 fixed, seamonkey2.21 fixed, seamonkey2.22 fixed)
RESOLVED
FIXED
seamonkey2.22
People
(Reporter: neil, Assigned: neil)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.72 KB,
patch
|
iannbugzilla
:
review+
philip.chee
:
feedback+
iannbugzilla
:
approval-comm-aurora+
Callek
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
Steps to reproduce problem:
1. Start with a private window
2. Open a browser window
3. Close the private window
4. Note the recently closed window list
5. Open another private window
6. Close the private window
7. Note the recently closed window list
This happens because there are two ways for Session Store to notice a window, the first is by the window calling init, and the second is by Session Store looking for browser windows once it's been initialised. Session Store tries to avoid finding non-browser windows but this doesn't seem to work as I expect, there's probably a race condition somewhere (I think it manages to add its onload handler first).
|
Assignee | |
Comment 1•12 years ago
|
||
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #767488 -
Flags: review?(iann_bugzilla)
Attachment #767488 -
Flags: feedback?(philip.chee)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 767488 [details] [diff] [review]
Proposed patch
OK this is WFM so f=me.
Attachment #767488 -
Flags: feedback?(philip.chee) → feedback+
Comment on attachment 767488 [details] [diff] [review]
Proposed patch
r=me
Attachment #767488 -
Flags: review?(iann_bugzilla) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
status-seamonkey2.19:
--- → wontfix
status-seamonkey2.20:
--- → affected
status-seamonkey2.21:
--- → affected
status-seamonkey2.22:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.22
|
|
Assignee | |
Comment 5•12 years ago
|
||
Comment on attachment 767488 [details] [diff] [review]
Proposed patch
[Approval Request Comment]
User impact if declined: Privacy leak
Risk to taking this patch (and alternatives if risky): Low
String changes made by this patch: None
Attachment #767488 -
Flags: approval-comm-beta?
Attachment #767488 -
Flags: approval-comm-aurora?
Attachment #767488 -
Flags: approval-comm-aurora? → approval-comm-aurora+
|
|
Assignee | |
Comment 6•12 years ago
|
||
|
||
Comment 7•12 years ago
|
||
Comment on attachment 767488 [details] [diff] [review]
Proposed patch
Review of attachment 767488 [details] [diff] [review]:
-----------------------------------------------------------------
a-beta=me, a-CLOSED_TREE=me
Attachment #767488 -
Flags: approval-comm-beta? → approval-comm-beta+
|
|
Assignee | |
Comment 8•12 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•