Closed Bug 887045 Opened 6 years ago Closed 6 years ago

Private windows opened after normal windows appear in recently closed window list

Categories

(SeaMonkey :: Session Restore, defect)

defect
Not set

Tracking

(seamonkey2.19 wontfix, seamonkey2.20 fixed, seamonkey2.21 fixed, seamonkey2.22 fixed)

RESOLVED FIXED
seamonkey2.22
Tracking Status
seamonkey2.19 --- wontfix
seamonkey2.20 --- fixed
seamonkey2.21 --- fixed
seamonkey2.22 --- fixed

People

(Reporter: neil, Assigned: neil)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Steps to reproduce problem:
1. Start with a private window
2. Open a browser window
3. Close the private window
4. Note the recently closed window list
5. Open another private window
6. Close the private window
7. Note the recently closed window list

This happens because there are two ways for Session Store to notice a window, the first is by the window calling init, and the second is by Session Store looking for browser windows once it's been initialised. Session Store tries to avoid finding non-browser windows but this doesn't seem to work as I expect, there's probably a race condition somewhere (I think it manages to add its onload handler first).
Attached patch Proposed patchSplinter Review
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #767488 - Flags: review?(iann_bugzilla)
Attachment #767488 - Flags: feedback?(philip.chee)
Comment on attachment 767488 [details] [diff] [review]
Proposed patch

OK this is WFM so f=me.
Attachment #767488 - Flags: feedback?(philip.chee) → feedback+
Comment on attachment 767488 [details] [diff] [review]
Proposed patch

r=me
Attachment #767488 - Flags: review?(iann_bugzilla) → review+
Pushed comm-central changeset 2beded163a35.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.22
Comment on attachment 767488 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
User impact if declined: Privacy leak
Risk to taking this patch (and alternatives if risky): Low
String changes made by this patch: None
Attachment #767488 - Flags: approval-comm-beta?
Attachment #767488 - Flags: approval-comm-aurora?
Attachment #767488 - Flags: approval-comm-aurora? → approval-comm-aurora+
Comment on attachment 767488 [details] [diff] [review]
Proposed patch

Review of attachment 767488 [details] [diff] [review]:
-----------------------------------------------------------------

a-beta=me, a-CLOSED_TREE=me
Attachment #767488 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.