The default bug view has changed. See this FAQ.

Private windows opened after normal windows appear in recently closed window list

RESOLVED FIXED in seamonkey2.22

Status

SeaMonkey
Session Restore
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

(Blocks: 1 bug)

unspecified
seamonkey2.22

SeaMonkey Tracking Flags

(seamonkey2.19 wontfix, seamonkey2.20 fixed, seamonkey2.21 fixed, seamonkey2.22 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Steps to reproduce problem:
1. Start with a private window
2. Open a browser window
3. Close the private window
4. Note the recently closed window list
5. Open another private window
6. Close the private window
7. Note the recently closed window list

This happens because there are two ways for Session Store to notice a window, the first is by the window calling init, and the second is by Session Store looking for browser windows once it's been initialised. Session Store tries to avoid finding non-browser windows but this doesn't seem to work as I expect, there's probably a race condition somewhere (I think it manages to add its onload handler first).
(Assignee)

Comment 1

4 years ago
Created attachment 767488 [details] [diff] [review]
Proposed patch
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #767488 - Flags: review?(iann_bugzilla)
Attachment #767488 - Flags: feedback?(philip.chee)

Comment 2

4 years ago
Comment on attachment 767488 [details] [diff] [review]
Proposed patch

OK this is WFM so f=me.
Attachment #767488 - Flags: feedback?(philip.chee) → feedback+

Comment 3

4 years ago
Comment on attachment 767488 [details] [diff] [review]
Proposed patch

r=me
Attachment #767488 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 4

4 years ago
Pushed comm-central changeset 2beded163a35.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-seamonkey2.19: --- → wontfix
status-seamonkey2.20: --- → affected
status-seamonkey2.21: --- → affected
status-seamonkey2.22: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.22
(Assignee)

Comment 5

4 years ago
Comment on attachment 767488 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
User impact if declined: Privacy leak
Risk to taking this patch (and alternatives if risky): Low
String changes made by this patch: None
Attachment #767488 - Flags: approval-comm-beta?
Attachment #767488 - Flags: approval-comm-aurora?

Updated

4 years ago
Attachment #767488 - Flags: approval-comm-aurora? → approval-comm-aurora+
(Assignee)

Comment 6

4 years ago
http://hg.mozilla.org/releases/comm-aurora/rev/d595ece2c097
status-seamonkey2.21: affected → fixed
Comment on attachment 767488 [details] [diff] [review]
Proposed patch

Review of attachment 767488 [details] [diff] [review]:
-----------------------------------------------------------------

a-beta=me, a-CLOSED_TREE=me
Attachment #767488 - Flags: approval-comm-beta? → approval-comm-beta+
(Assignee)

Comment 8

4 years ago
http://hg.mozilla.org/releases/comm-beta/rev/ad06842957a1
status-seamonkey2.20: affected → fixed
You need to log in before you can comment on or make changes to this bug.