887120 - Using tap & hold to paste into URL App Bar doesn't launch "Search" while right clicking does

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: App Bar, defect, P2)

Description

[Kamil Jozwiak [:kjozwiak]]

When pasting into the URL bar using the tap and hold method, the "Your Results" & "Internet Searches" will NOT be launched on the awesome screen, but if you use the right click method you will notice that both "Your Results" and "Internet Searches" will appear. I am not sure which method is using correct behavior but it should be consistent throughout both methods.

Steps to reproduce the issue:

1) Open Firefox Metro (ensure that you have something in the clipboard you can paste)
2) On the awesome screen, tap and hold on the URL App Bar and then release, select "Paste" from the context menu (nothing will occur)
3) Close Firefox Metro & re-open Firefox Metro
4) This time, right click on the URL App Bar and select "Paste". You will notice the "Your Results" & "Internet Searches" columns appear

Current Behavior:

- "Tap and Hold" and "Right Clicking" are not consistent when pasting something into the URL App Bar under the awesome screen

Expected Behavior:

- Should be consistent through both ways of pasting. Either we display both the "Your Results" & "Internet Searches" columns or we don't when pasting.

Comment 1

[Jim Mathies [:jimm]]

When I do this I get two context menu options from the tap and hold - paste and paste and go. Which seems correct. Right clicking with the mouse I getthe same.

Comment 2

[Jim Mathies [:jimm]]

The start screen also updates and displays Your results and Internet Searches.

Comment 3

[Kamil Jozwiak [:kjozwiak]]

Attachment: video of issue occurring

Jim, I reproduced the same problem with the latest version of Nightly. Attached a short video that will hopefully help you reproduce the problem.

Comment 4

[Jim Mathies [:jimm]]

Key issue here, you have to paste without first tapping, so that the urlbar doesn't have focus.

Comment 5

[Jim Mathies [:jimm]]

Attachment: fix

This fixes the issue. Feel free to include something like this in your autocomplete work if you want, I know this code is about to get a big overhaul.

Comment 6

[Jonathan Wilde [:jwilde]]

The actual fix will land with the refactoring in 883390, but I'd like to use this bug to land a regression test for this fix.

Comment 7

[Jonathan Wilde [:jwilde]]

Attachment: failing testcase

Comment 8

[Jonathan Wilde [:jwilde]]

Fixed with bug 883390.