Closed Bug 887120 Opened 7 years ago Closed 7 years ago

Using tap & hold to paste into URL App Bar doesn't launch "Search" while right clicking does

Categories

(Firefox for Metro Graveyard :: App Bar, defect, P2)

x86_64
Windows 8.1
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kjozwiak, Assigned: jwilde)

References

Details

Attachments

(3 files)

When pasting into the URL bar using the tap and hold method, the "Your Results" & "Internet Searches" will NOT be launched on the awesome screen, but if you use the right click method you will notice that both "Your Results" and "Internet Searches" will appear. I am not sure which method is using correct behavior but it should be consistent throughout both methods.

Steps to reproduce the issue:

1) Open Firefox Metro (ensure that you have something in the clipboard you can paste)
2) On the awesome screen, tap and hold on the URL App Bar and then release, select "Paste" from the context menu (nothing will occur)
3) Close Firefox Metro & re-open Firefox Metro
4) This time, right click on the URL App Bar and select "Paste". You will notice the "Your Results" & "Internet Searches" columns appear

Current Behavior:

- "Tap and Hold" and "Right Clicking" are not consistent when pasting something into the URL App Bar under the awesome screen

Expected Behavior:

- Should be consistent through both ways of pasting. Either we display both the "Your Results" & "Internet Searches" columns or we don't when pasting.
When I do this I get two context menu options from the tap and hold - paste and paste and go. Which seems correct. Right clicking with the mouse I getthe same.
The start screen also updates and displays Your results and Internet Searches.
Jim, I reproduced the same problem with the latest version of Nightly. Attached a short video that will hopefully help you reproduce the problem.
Priority: -- → P2
Key issue here, you have to paste without first tapping, so that the urlbar doesn't have focus.
Attached patch fixSplinter Review
This fixes the issue. Feel free to include something like this in your autocomplete work if you want, I know this code is about to get a big overhaul.
Assignee: nobody → jmathies
Attachment #770123 - Flags: review?(jwilde)
Whiteboard: feature=defect c=main_ui_reorganization u=metro_firefox_user p=0 → feature=defect c=main_ui_reorganization u=metro_firefox_user p=1
Blocks: metrov1it10
No longer blocks: metrov1defect&change
Status: NEW → ASSIGNED
QA Contact: jbecerra
No longer blocks: metrov1it10
Summary: Defect - Using tap & hold to paste into URL App Bar doesn't launch "Search" while right clicking does → Using tap & hold to paste into URL App Bar doesn't launch "Search" while right clicking does
Whiteboard: feature=defect c=main_ui_reorganization u=metro_firefox_user p=1
Attachment #770123 - Flags: review?(jwilde)
Assignee: jmathies → nobody
Assignee: nobody → jwilde
The actual fix will land with the refactoring in 883390, but I'd like to use this bug to land a regression test for this fix.
Blocks: 883390
No longer blocks: 835623
Attached patch failing testcaseSplinter Review
Fixed with bug 883390.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.