Story - Combine page contextual items (URL bar, bookmark star, etc.) into single app bar

VERIFIED FIXED in Firefox 24

Status

P2
normal
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: fryn, Assigned: fryn)

Tracking

Trunk
Firefox 24
All
Windows 8.1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: feature=story c=main_ui_reorganization u=metro_firefox_user p=5, URL)

Attachments

(1 attachment, 1 obsolete attachment)

24.79 KB, patch
mbrubeck
: review+
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
Combine page contextual items (URL bar, bookmark star, etc.) into a single app bar at the bottom of the screen.
(Assignee)

Updated

6 years ago
Assignee: nobody → fyan
Status: NEW → ASSIGNED
Blocks: 838211
Priority: -- → P1

Updated

6 years ago
Blocks: 845152
Summary: Combine page contextual items (URL bar, bookmark star, etc.) into single app bar → Work - Combine page contextual items (URL bar, bookmark star, etc.) into single app bar

Updated

6 years ago
Whiteboard: feature=work c=main_ui_reorganization u=metro_firefox_user
No longer blocks: 838211
Whiteboard: feature=work c=main_ui_reorganization u=metro_firefox_user → feature=work
Priority: P1 → P5
Hey Asa, this requires a new story.
Assignee: fyan → nobody
Blocks: 845137, 839336
Summary: Work - Combine page contextual items (URL bar, bookmark star, etc.) into single app bar → Story - Combine page contextual items (URL bar, bookmark star, etc.) into single app bar
Whiteboard: feature=work → feature=story c=main_ui_reorganization u=metro_firefox_user p=5
No longer blocks: 845152
(Assignee)

Comment 2

6 years ago
Created attachment 723627 [details] [diff] [review]
WIP

WIP from a while ago before I had design guidance from Stephen.
Complete patch coming soon.
Story is on hold.

Updated

6 years ago
Depends on: 800996
This story probably shouldn't be on hold. This is the last major UI re-shuffling and we should try to get it completed in the next iteration if at all possible.
Hi Asa, it was only on hold because it required a user story.  Once it is supplied this bug can be moved to the story backlog for selection.
Status: ASSIGNED → NEW
Flags: needinfo?(asa)
Blocks: 841997
No longer blocks: 839336
(Assignee)

Updated

6 years ago
No longer blocks: 835622
(Assignee)

Comment 6

6 years ago
Now that bug 800996 has landed (on mozilla-inbound and next mozilla-central shortly), I'm taking this as I am sitting in the same room as Stephen and Yuan (of UX) everyday this week, who will be able to provide all the UX guidance I need to finish this story. If I don't have a patch up by the end of this iteration, I'll relinquish this bug to avoid blocking other folks.
Assignee: nobody → fyan
(Assignee)

Updated

6 years ago
Status: NEW → ASSIGNED
Story: 

As a Metro Firefox user, I have quick and convenient access to the Firefox app bar so that I can identify the current page, edit and load addresses, navigate back and forward, reload the page, bookmark pages, find in page, view in desktop, and pin  to Windows Start. 

Flow: 

1. The Metro user opens the website http://www.cnn.com
2. The Metro Firefox user swipes in from the top or bottom of the screen and sees a beautiful Firefox app bar appear at the bottom of the page.
3. The user looks over the app bar and sees a back button, address field, reload button, star and pin to start buttons.
Flags: needinfo?(asa)
Blocks: 838081
No longer blocks: 841997
Blocks: 855905
No longer blocks: 838081
Priority: P5 → P2
QA Contact: jbecerra
Blocks: 862352
No longer blocks: 855905
Depends on: 867543

Updated

6 years ago
Blocks: 867616
Blocks: 831942
(Assignee)

Comment 8

6 years ago
Created attachment 749038 [details] [diff] [review]
patch

If the patch in bug 869777 hasn't landed yet, apply the patch in bug 869777 first.
Attachment #723627 - Attachment is obsolete: true
Attachment #749038 - Flags: review?(mbrubeck)
(Assignee)

Updated

6 years ago
Depends on: 869777

Updated

6 years ago
Depends on: 857437
Comment on attachment 749038 [details] [diff] [review]
patch

Review of attachment 749038 [details] [diff] [review]:
-----------------------------------------------------------------

Everything in this patch looks good to me, but there's a problem somewhere (I don't know where) with snapped view.  We don't need to get snapped view working *perfectly* to land this, but could you look into this and see if there's an easy way to restore basic functionality before landing?
Attachment #749038 - Flags: review?(mbrubeck) → review+
(Assignee)

Comment 10

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b994338768d

(In reply to Matt Brubeck (:mbrubeck) from comment #9)
> Everything in this patch looks good to me, but there's a problem somewhere
> (I don't know where) with snapped view.  We don't need to get snapped view
> working *perfectly* to land this, but could you look into this and see if
> there's an easy way to restore basic functionality before landing?

Yeah, I added the following rule to address this for now:

#toolbar[viewstate="snapped"] > #tool-stop ~ toolbarbutton {
  visibility: collapse;
}
https://hg.mozilla.org/mozilla-central/rev/8b994338768d
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Target Milestone: --- → Firefox 24
No longer depends on: 857437
No longer depends on: 867543
For testing and verification.
Flags: needinfo?(jbecerra)
Depends on: 872679
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Canceling test request until final dependency is resolved.
Flags: needinfo?(jbecerra)
(Assignee)

Updated

6 years ago
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
For testing and verification.
Flags: needinfo?(virgil.dicu)

Updated

6 years ago
Depends on: 875448
Depends on: 875892
Depends on: 876401
Flags: needinfo?(virgil.dicu)
Depends on: 876406
Depends on: 876408
Mozilla/5.0 (Windows NT 6.2; rv:24.0) Gecko/20130526 Firefox/24.0

- verified that app bar is invoked with Ctrl + Z and right click
- items specified in comment 7 are displayed in the app bar - apart from the reload button (bug 876406): Back/Forward buttons, address bar, Downloads, Zoom In, Zoom Out, Bookmark, Pin, Tool button (with View in Desktop and Find options)
-items are functional - apart from Zoom in/Out (bug 876408)

Also logged bug 876401 and bug 876417 in addition to the ones mentioned above. 

I've logged separate bugs for every issue, so this can be set to verified.
Status: RESOLVED → VERIFIED
No longer depends on: 876401
Depends on: 878531
Depends on: 878618
Depends on: 878619
Depends on: 887120
Depends on: 887138
Went through the following "Story" for iteration #9 testing and found several issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-06-25-03-12-38-mozilla-central/

- Used the "Combined App Bar" and most of the bugs are still issues (Bug 878531, Bug 878618, Bug 878619)
- Found two new defects that are related to the "Combined App Bar" (Bug 887120, Bug 887138)
Depends on: 888523
No longer depends on: 887120
Depends on: 867543
No longer depends on: 867543
No longer depends on: 887138
User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130812030209
Built from http://hg.mozilla.org/mozilla-central/rev/87c1796bc46c

WFM
Tested on windows 8 using latest nightly for iteration-11. I saw a back button, address field, reload button, star and pin buttons in app bar.
No longer depends on: 878531
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.