Closed
Bug 887236
Opened 11 years ago
Closed 11 years ago
prefix the current events in workers with "Worker"
Categories
(Core :: DOM: Workers, defect)
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: smaug, Assigned: smaug)
References
Details
(Keywords: dev-doc-complete, site-compat)
Attachments
(1 file)
3.83 KB,
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
...the same way as what we have in the main thread. That way we can start using the real DOM events in workers without any hacks in them.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → bugs
Assignee | ||
Comment 1•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=b81f1f6c9fc4 This is regression risky, but I don't know how else to deal with this. Eventually all the events should be DOM events ofc.
Attachment #767736 -
Flags: review?(bent.mozilla)
I wouldn't worry too much about this breaking things. I don't think these interfaceobjects are used terribly much. Though it would be good to land this early in a cycle and then hope that a lot of the followup patches to use more xpcom Events in workers can land in the same cycle.
Updated•11 years ago
|
Attachment #767736 -
Flags: review?(bent.mozilla) → review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/794da9907814
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/794da9907814
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Updated•11 years ago
|
Keywords: dev-doc-needed,
site-compat
Comment 5•11 years ago
|
||
Added: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/25/Site_Compatibility
Keywords: dev-doc-needed → dev-doc-complete
Comment 6•11 years ago
|
||
I switched back the doc flag as there much more doc needed for this bug: we need to actually document WorkerEvent and co :-) BTW, I wasn't able to find the spec where these interfaces are specified. Anybody knows about it? Thanks in advance.
Keywords: dev-doc-complete → dev-doc-needed
Comment 7•11 years ago
|
||
We shouldn't document the Worker* variants, IMO. They're broken versions of the Event interfaces, only exposed to workers; they're being renamed because we're going to implement the correct main-thread implementations to workers.
Assignee | ||
Comment 8•11 years ago
|
||
There are Worker* events also in the main thread, in case events are dispatched to main thread Worker. But yes, all the Worker* events are just temporary and we're trying to get rid of them asap.
Comment 9•11 years ago
|
||
So I switch back to dev-doc-complete :-) Thanks for the explanation!
Keywords: dev-doc-needed → dev-doc-complete
Comment 10•11 years ago
|
||
I think the site-compat doc should explain that the change is temporary.
Comment 11•11 years ago
|
||
Fixed the description in the compatibility doc.
Comment 12•11 years ago
|
||
Can you please point me to the bug that undoes the change?
Comment 13•11 years ago
|
||
Filed bug 921485.
Comment 14•11 years ago
|
||
The temporary "Worker" prefix was removed again by bug 928312.
Comment 15•11 years ago
|
||
(In reply to Masatoshi Kimura [:emk] from comment #14) > The temporary "Worker" prefix was removed again by bug 928312. OK, will add a note to the 28 compat doc :)
You need to log in
before you can comment on or make changes to this bug.
Description
•