The default bug view has changed. See this FAQ.

prefix the current events in workers with "Worker"

RESOLVED FIXED in mozilla25

Status

()

Core
DOM: Workers
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

({dev-doc-complete, site-compat})

unspecified
mozilla25
x86_64
Linux
dev-doc-complete, site-compat
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

3.83 KB, patch
Ben Turner (not reading bugmail, use the needinfo flag!)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

4 years ago
...the same way as what we have in the main thread.
That way we can start using the real DOM events in workers without any hacks in them.
(Assignee)

Updated

4 years ago
Assignee: nobody → bugs
(Assignee)

Updated

4 years ago
Blocks: 887239
(Assignee)

Comment 1

4 years ago
Created attachment 767736 [details] [diff] [review]
patch

https://tbpl.mozilla.org/?tree=Try&rev=b81f1f6c9fc4

This is regression risky, but I don't know how else to deal with this.
Eventually all the events should be DOM events ofc.
Attachment #767736 - Flags: review?(bent.mozilla)
I wouldn't worry too much about this breaking things. I don't think these interfaceobjects are used terribly much. Though it would be good to land this early in a cycle and then hope that a lot of the followup patches to use more xpcom Events in workers can land in the same cycle.
Attachment #767736 - Flags: review?(bent.mozilla) → review+
(Assignee)

Comment 3

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/794da9907814
https://hg.mozilla.org/mozilla-central/rev/794da9907814
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25

Updated

4 years ago
Keywords: dev-doc-needed, site-compat
Added: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/25/Site_Compatibility
Keywords: dev-doc-needed → dev-doc-complete
I switched back the doc flag as there much more doc needed for this bug: we need to actually document WorkerEvent and co :-)

BTW, I wasn't able to find the spec where these interfaces are specified. Anybody knows about it?

Thanks in advance.
Keywords: dev-doc-complete → dev-doc-needed
We shouldn't document the Worker* variants, IMO. They're broken versions of the Event interfaces, only exposed to workers; they're being renamed because we're going to implement the correct main-thread implementations to workers.
(Assignee)

Comment 8

4 years ago
There are Worker* events also in the main thread, in case events are dispatched to main thread Worker.
But yes, all the Worker* events are just temporary and we're trying to get rid of them asap.
So I switch back to dev-doc-complete :-) Thanks for the explanation!
Keywords: dev-doc-needed → dev-doc-complete
I think the site-compat doc should explain that the change is temporary.
Fixed the description in the compatibility doc.

Comment 12

4 years ago
Can you please point me to the bug that undoes the change?
Depends on: 921485
Filed bug 921485.
The temporary "Worker" prefix was removed again by bug 928312.
(In reply to Masatoshi Kimura [:emk] from comment #14)
> The temporary "Worker" prefix was removed again by bug 928312.

OK, will add a note to the 28 compat doc :)
You need to log in before you can comment on or make changes to this bug.