Closed Bug 887319 Opened 11 years ago Closed 11 years ago

minimize/tear-off/close icons of chat windows are pixelated on a retina screen

Categories

(Firefox Graveyard :: SocialAPI, defect)

Product:
Firefox Graveyard
Component:
SocialAPI
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(firefox23 unaffected, firefox24 fixed, firefox25 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 25
Tracking Flags:
Tracking Status
firefox23 --- unaffected
firefox24 --- fixed
firefox25 --- verified

People

(Reporter: florian, Assigned: florian)

Details

Attachments

(5 files, 3 obsolete files)

Screenshot
1.65 KB, image/png
Details
Icons: Close/minimize/popout retina for upper right of chat window (default and click state), as one image for mxr
9.36 KB, application/zip
Details
Patch v2
32.90 KB, patch
mconley
: review+
bajaj
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Screenshot
9.93 KB, image/png
Details
Patch V2 Fx24
32.61 KB, patch
Details | Diff | Splinter Review 
My guess is that the file browser/themes/osx/social/chat-icons.png needs an @2x.png version.
Attached image Screenshot — 

    
    

    
  
Boriss, can you get us the @2 icons for the chat window controls?
Assignee: nobody → jboriss
Keywords: uiwanted

    
    

    
  
@Boriss ping

    
    

    
  

      
      
      
      

        Attached image
          
        Screenshot with attachment 776277 (obsolete)
        — 
      

    


  
Attachment 776277 [details] used on the left side of the screenshot, and a current nightly on the right side to compare.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch (obsolete)
        — 
          — Splinter Review
      

    


  
Patch used to make the screenshot in attachment 776295 [details].

    
    

    
  


  
On Florian's suggestion, redid icons to be consistent with OSX tab controls, suspect it'll look more visually consistent

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch v2
        — 
          — Splinter Review
      

    


  
This uses 16x16px (and 32x32px for retina) icons to be more consistent with the camera icon, and tab icons.
Assignee: jboriss → florian

        Attachment #776277 -
        Attachment is obsolete: true

        Attachment #776295 -
        Attachment is obsolete: true

        Attachment #776297 -
        Attachment is obsolete: true

        Attachment #780384 -
        Flags: review?(mixedpuppy)

    
    

    
  

      
      
      
      

        Attached image
          
        Screenshot
        — 
      

    


  
With attachment 780384 [details] [diff] [review] on the left side; with a current nightly on the right side.

    
  
Keywords: uiwanted

    
    

    
  
Comment on attachment 780384 [details] [diff] [review]
Patch v2

looks ok to me, but get a reviewer to look

        Attachment #780384 -
        Flags: review?(mixedpuppy) → review?(mconley)

    
    

    
  
Comment on attachment 780384 [details] [diff] [review]
Patch v2

Review of attachment 780384 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

        Attachment #780384 -
        Flags: review?(mconley) → review+

    
    

    
  
Comment on attachment 780384 [details] [diff] [review]
Patch v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 880911
User impact if declined: ugly icons on retina display
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

        Attachment #780384 -
        Flags: approval-mozilla-aurora?

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/02e569264881
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25

        Attachment #780384 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Keywords: verifyme

    
    

    
  
Needs a branch-specific patch for uplift.

          status-firefox25:
          affected → fixed
Flags: needinfo?(florian)
Keywords: branch-patch-needed

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch V2 Fx24
        — 
          — Splinter Review
      

    


  
branch patch
Flags: needinfo?(florian)

    
    

    
  
Matt, can you please verify this is fixed in Firefox 25?
QA Contact: mwobensmith

    
    

    
  
Confirmed problem on FF25, 2013-06-26.
Verified fixed on FF25, 2013-10-21.
Status: RESOLVED → VERIFIED

          status-firefox25:
          fixed → verified
Keywords: verifyme

    
  
Product: Firefox → Firefox Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: