887397 - Window click and drag target is too small

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Chenxia Liu [:liuche]]

The target for dragging a window is much smaller than the original, probably less than half the size. However, with the fading of the top tab, the click-drag target appears to be larger, and even after having used Australis for a while, I find myself overshooting the target ALL THE TIME because I can't see the top of the tab.

A possible suggestion would be to shrink the mouse-over target for activating the tab-highlight so it is lower than the top of the tab.

Comment 1

[Justin Dolske [:Dolske]]

Not sure there's much actionable here. The draggable target is overall smaller with tabs-in-titlebar, yes. Also true that the top of background tabs may look like a draggable thing until mouseover (especially when moving downwards, so there's less time for the :hover style to register). And all the arguments would apply in reverse for selecting a tab when you didn't want to drag it, if we changed this.

Comment 3

[Matthew N. [:MattN]]

Reopening because there is possibly something that can be done for all tabs including selected ones as there is a pixel or two above the stroke (with a glow) that doesn't need to be clickable/draggable. We will need to evaluate the cost/benefit ratio for fixing.

Comment 4

[Benoit Girard (:BenWa)]

(I wrote this before Comment 3 was posted)

I disagree with wontfix. The drag area is too small and is a serious problem for people without fine motor skills. I even struggle with it. Note that the tab mouse over seems to register 1-2 pixels early. I count about 6 pixels I can use to drag which is 0.5% of my monitor height which is increasingly difficult to select reliably.

Can we re-open this bug? If it's up to me I'd make the tabs shorter (A lot of wasted space above/under the tab text that I would prefer to have in the title bar).

Comment 5

[Matthew N. [:MattN]]

As discussed at the Paris work week, we should reduce the pointer-event area from background tabs to increase the area to drag the titlebar in cases where we aren't trying to achieve gains from Fitts' Law (e.g. restored windows).

Comment 6

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Attachment: Illustration of the dragable area

Adding a quick illustration of the area that should be dragable.
The hover effect of the background tabs should not trigger above the line.
This only applies when the window is not in full screen mode (in which case the behavior should be the same as it is today).
We might need to adjust the exact threshold a little when we get to actually test this.

Comment 7

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Also, the behavior of the currently selected tab shouldn't change at any time.

Comment 8

[Eric Shepherd [:sheppy]]

So very glad this is being looked at; my hands have developed a tremor the last few months, and the very small grab-and-drag area has been very frustrating. I've turned back on the title bar, but that's sort of a stop-gap measure, since I'm not at all convinced that ability will stick around over the long term. :)

Comment 9

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Attachment: Space next to new tab button

One more thing we can do: make the area to the right of the new tab button dragable (see attachment: red area or area to the right of the line). Evidently, we already do that with the first tab.

Comment 10

[Matthew N. [:MattN]]

I can give this a try. I won't know how easy it will be until I dig into it though.

Comment 11

[Madhava Enros [:madhava]]

(In reply to Eric Shepherd [:sheppy] from comment #8)
> So very glad this is being looked at; my hands have developed a tremor the
> last few months, and the very small grab-and-drag area has been very
> frustrating. I've turned back on the title bar, but that's sort of a
> stop-gap measure, since I'm not at all convinced that ability will stick
> around over the long term. :)

FWIW, on this front, there's now a toggle in the customization mode to show/hide the titlebar. This is, in part, a result of your feedback, Sheppy.

Comment 12

[Eric Shepherd [:sheppy]]

(In reply to Madhava Enros [:madhava] from comment #11)

> FWIW, on this front, there's now a toggle in the customization mode to
> show/hide the titlebar. This is, in part, a result of your feedback, Sheppy.

The added options in the customization mode are a great improvement; thanks! Making it a little easier to drag while in draw-in-title mode will be an even bigger help, especially for folks that do prefer that display mode.

Comment 13

[Matthew N. [:MattN]]

Attachment: v.1 Use a clip-path on tab-background-middle

Waiting for talos results before requesting review.

Try push for talos:
Baseline: https://tbpl.mozilla.org/?tree=Try&rev=f62367b7e349
v.1:      https://tbpl.mozilla.org/?tree=Try&rev=e5d8a516209f

http://compare-talos.mattn.ca/?oldRevs=f62367b7e349&newRev=e5d8a516209f&submit=true

Comment 14

[Matthew N. [:MattN]]

Comment on attachment 8386456 [details] [diff] [review]
v.1 Use a clip-path on tab-background-middle

Review of attachment 8386456 [details] [diff] [review]:
-----------------------------------------------------------------

Still waiting for some retriggers to come in but this seems okay so far.

Comment 15

[:Gijs (he/him)]

Comment on attachment 8386456 [details] [diff] [review]
v.1 Use a clip-path on tab-background-middle

Review of attachment 8386456 [details] [diff] [review]:
-----------------------------------------------------------------

Sweet!

Comment 16

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/fx-team/rev/5bb78bdc6c5c

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5bb78bdc6c5c

Comment 19

[Matthew N. [:MattN]]

Comment on attachment 8386456 [details] [diff] [review]
v.1 Use a clip-path on tab-background-middle

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Tabs in titlebar
User impact if declined: Hard to drag the window above background tabs without accidentally dragging a tab when tabs are in the titlebar.
Testing completed (on m-c, etc.): m-c and UX approved (phlsa)
Risk to taking this patch (and alternatives if risky): Low risk. Potential for perf impact but it was negligible on m-c.
String or IDL/UUID changes made by this patch: None

Comment 20

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e72e46d55abc

Comment 21

[arminwagner2008]

Thank you for working on this!

The draggable area is still a bit too small for my taste, so I reactivated the titlebar. However, on OSX I thought I would find the show/hide option in the View-Application Menu. I didn't expect to find it in the bottom-left corner of the customization window (I didn't know this button existed until I read the comments of this bug report).

Comment 22

[Eric Shepherd [:sheppy]]

(In reply to arminwagner2008 from comment #21)
> Thank you for working on this!
> 
> The draggable area is still a bit too small for my taste, so I reactivated
> the titlebar. However, on OSX I thought I would find the show/hide option in
> the View-Application Menu. I didn't expect to find it in the bottom-left
> corner of the customization window (I didn't know this button existed until
> I read the comments of this bug report).

I do agree that this option should be listed in the main menu bar somewhere, probably in the View menu.

Comment 23

[:Gijs (he/him)]

(In reply to Eric Shepherd [:sheppy] from comment #22)
> (In reply to arminwagner2008 from comment #21)
> > Thank you for working on this!
> > 
> > The draggable area is still a bit too small for my taste, so I reactivated
> > the titlebar. However, on OSX I thought I would find the show/hide option in
> > the View-Application Menu. I didn't expect to find it in the bottom-left
> > corner of the customization window (I didn't know this button existed until
> > I read the comments of this bug report).
> 
> I do agree that this option should be listed in the main menu bar somewhere,
> probably in the View menu.

Please file a new bug instead of "me too" ing in here.