887438 - Add currentset setter shim for all toolbars

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[:Gijs (he/him)]

As just discussed, it's probably a good idea to have a backwards compatibility thing for the currentSet setter.

Comment 1

[:Gijs (he/him)]

Attachment: Patch with tests

Comment 2

[:Gijs (he/him)]

Comment on attachment 771616 [details] [diff] [review]
Patch with tests

>diff --git a/browser/components/customizableui/test/head.js b/browser/components/customizableui/test/head.js
> function getAreaWidgetIds(areaId) {
>-  let widgetAry = CustomizableUI.getWidgetsInArea(areaId);
>-  return widgetAry.map(x => x.id);
>+  return CustomizableUI.getWidgetIdsInArea(areaId);
> }

I guess this is unrelated because I didn't really use it in this test, but now that we have an API for this I figured we should probably not wrap and unwrap these in our tests... it's a little silly.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 771616 [details] [diff] [review]
Patch with tests

Review of attachment 771616 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/customizableui/content/toolbar.xml
@@ +133,4 @@
>          ]]></getter>
>        </property>
>  
>        <property name="currentSet" readonly="true">

Now that there is a setter, readonly=true seems wrong.

::: browser/components/customizableui/test/browser_887438_currentset_shim.js
@@ +34,5 @@
> +      is(newCurrentSet, navbar.currentSet, "Current set should match expected current set.");
> +      let feedBtn = document.getElementById("feed-button");
> +      let syncBtn = document.getElementById("sync-button");
> +      ok(feedBtn, "Feed button should have been added.");
> +      ok(syncBtn, "Sync button should have been added.");

Please add a check that feedBtn.nextElementSibling == syncBtn as well as syncBtn.nextElementSibling == homeButton.

Comment 4

[:Gijs (he/him)]

Pushed with the issues from comment #3 fixed: https://hg.mozilla.org/projects/ux/rev/1b4535123806

Comment 5

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/1b4535123806