887646 - B2G MMS: Do not set content-length in smil header when sending.

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

We don't need to set set content-length in smil header when sending. In some operators they will rewrite the smil. If we set content-length, some operators might skip the recalculating of new smil.

Comment 1

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Block a leo+ bug, nominate to leo+.

Comment 2

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Patch v1.0

Comment 3

[Dietrich Ayala (:dietrich)]

Blocks a blocker -> blocking.

Comment 4

[Gene Lian (I already quit Mozilla)]

Comment on attachment 768165 [details] [diff] [review]
Patch v1.0

Review of attachment 768165 [details] [diff] [review]:
-----------------------------------------------------------------

It doesn't solve the real problem at bug 883019, but anyway we shouldn't set the SMIL.length as the content-length because the new length of the utf-8 encoding SMIL could be different. Removing this can also solve this potential issue.

Please do make sure this won't create any other regressions before landing.

Comment 5

[Gene Lian (I already quit Mozilla)]

https://hg.mozilla.org/projects/birch/rev/7c34ca069742
https://hg.mozilla.org/releases/mozilla-b2g18/rev/707ffca0b100

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7c34ca069742

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/707ffca0b100