Closed Bug 887682 Opened 7 years ago Closed 7 years ago

show the mozilla-corporation-confidential checkbox on show_bug to all mozilla-corporation-confidential-visible members

Categories

(bugzilla.mozilla.org :: General, defect)

Production
x86
macOS
defect
Not set
major

Tracking

()

RESOLVED FIXED

People

(Reporter: glob, Assigned: glob)

Details

Attachments

(2 files)

currently mozilla-corporation-confidential-visible controls the visibility of the mozilla-corporation-confidential field on the enter_bug page only.

partners need a way to mark existing bugs as mozilla-corporation-confidential.
Attached patch patch v1 β€” β€” Splinter Review
add groups to show_bug based on -visible membership.

- the groups are only shown on bugs which that user reported
- the groups are only visibile when the group would have been displayed to normal members
- the user can only place bugs into groups, not remove them
Attachment #768785 - Flags: review?(dkl)
Comment on attachment 768785 [details] [diff] [review]
patch v1

Review of attachment 768785 [details] [diff] [review]:
-----------------------------------------------------------------

Using user account where the user is in a -visible group, report a new bug, then from show_bug.cgi set the privacy group that is always settable. 
Observe that the user cannot unset the group which is correct. Then change the product to another product where the group is no longer available,
the user cannot check the group as it is unchecked and disabled. Hit verify product change anyway and get stuck in product verification loop.

dkl
Attachment #768785 - Flags: review?(dkl) → review-
i'm unable to replicate that problem on my system.  i'll grab you on irc for more details.
Comment on attachment 768785 [details] [diff] [review]
patch v1

Originally it was because I did not have the mozilla-corporation-confidential group enabled for the new product the bug was being moved to (sanitized dump import). So I then enabled the group properly and it moved without error. But it is not perfect (and unrelated to this bug) as it still showed that the mozilla-corp-conf group was not valid for the new product and that it would be moved. The checkbox was disabled and not checked. But when the change had completed, the bug was still in the moz-conp-conf group properly so the interim verification page was misleading. I will post a screenshot for your comment and to see if you get the same issue.

dkl
Attachment #768785 - Flags: review- → review+
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/
modified Bugzilla/Bug.pm
Committed revision 8870.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.