887706 - use a dynamic port in httpserver xpcshell tests so they can be run in parallel

Status: RESOLVED FIXED

(Testing :: General, defect)

Comment 1

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: use -1 as httpd port

Still need to figure out a way to do it for:
netwerk/test/httpserver/test/test_request_line_split_in_two_packets.js
netwerk/test/httpserver/test/test_sjs.js

Suggestions welcome!

Comment 2

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: fixed all the test, one is run sequentially

Comment 3

[Mihnea Dobrescu-Balaur (:mihneadb)]

Comment on attachment 770609 [details] [diff] [review]
fixed all the test, one is run sequentially

This is a pretty long patch but basically I used -1 as the "start" port and wrapped all that was needed in lazy getters.

Please note that this patch requires the run-sequentially functionality that is introduced by the patch in bug 887054 (on which this bug depends).

Comment 4

[Jeff Walden [:Waldo]]

Comment on attachment 770609 [details] [diff] [review]
fixed all the test, one is run sequentially

Review of attachment 770609 [details] [diff] [review]:
-----------------------------------------------------------------

Going full-out lazy for all of this is more than I'd have done if I were writing this.  Bunches of things here don't need to be lazy, exactly -- they just need to be delayed a little bit.  But these are all tests, so as long as readability is moderately preserved, and it is far enough here, it's not really worth putting extra effort into doing things exactly "right".

Comment 5

[Mihnea Dobrescu-Balaur (:mihneadb)]

try run: https://tbpl.mozilla.org/?tree=Try&rev=3cc3d0e1e923

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/290f46211dd1

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/290f46211dd1