Closed Bug 887064 Opened 11 years ago Closed 11 years ago

Make the xpcshell tests independent so they can run simultaneously

Categories

(Testing :: XPCShell Harness, defect)

x86_64
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mihneadb, Assigned: mihneadb)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 obsolete file)

Right now there are tests that cannot run concurrently (for example those that use httpd with a hardcoded 8080 port).
We need to fix this in order to land the parallel xpcshell suite.
Attached patch services/common/tests/unit (obsolete) — — Splinter Review
Assignee: nobody → mihneadb
Depends on: 886980
Blocks: parxpc
There needs to be some dupe action with bug 884421 or something.

Also, I recommend opening independent bugs for the larger chunks of this work under the components the tests are attached to. e.g. file an Add-on Manager bug to track updating just those tests. Add-on Manager is especially important because they are currently in the midst of a massive rewrite in bug 853388 and your test changes will likely conflict!

Finally, all these bugs should chain up to bug 660788 so we have a way to track the overall effort.
Depends on: 887404
needinfo myself to check what's up with Places tests
Flags: needinfo?(mak77)
ah there's a dependency bug, moving there
Flags: needinfo?(mak77)
Depends on: 887480
Depends on: 887543
Depends on: 887557
FWIW, there are quite a few tests in toolkit/ that use hardcoded ports; they tend to use port 4444.  I've started fixing them independently, though I'm not very far along.  I'll try to post some of the patches soon so we don't duplicate work.
That's great, thank you! Do you mind creating a patch and referencing it here in the depends section?
Thanks!
Depends on: 887578
Depends on: 887706
Blocks: 660788
Comment on attachment 767508 [details] [diff] [review]
services/common/tests/unit

Marking this patch as obsolete since
1. a separate bug needs to be filled for this, keeping bug 887064 (this one) as a tracking bug
2. :gps has offered to help with the services/ tests.
Attachment #767508 - Attachment is obsolete: true
No longer depends on: 886980
Depends on: 884421
Depends on: 888405
Depends on: 888526
Depends on: 888537
Depends on: 888544
Depends on: 888545
Depends on: 888550
Depends on: 888556
Depends on: 889034
Depends on: 889076
Depends on: 889102
Depends on: 889182
Depends on: 889183
Depends on: 890071
No longer blocks: parxpc
Depends on: 888350
Depends on: 890098
Depends on: 892121
Depends on: 892021
Depends on: 892765
As discussed on IRC, for Thunderbird and Seamonkey tests we could just add the run-sequentially ini flag to the manifests' default section. Support for that flag comes with the parallel harness, in bug 887054.
No longer blocks: 660788
Blocks: parxpc
No longer depends on: 894729
No longer depends on: 894728
Depends on: 895572
Here's a list of intermittent failures (and bugs) that I encountered so far doing try pushes with the patches applied:

indexedDB - 860714
jsdownloads - 865364
netwerk/backgroundfilesaver - 855757
devtools/dbgsocket - 775924
devtools/actor stuff - 810185
image - 867183
extensions/cookie/cookies_read - 595925, 601508, 587767
healthreporter - 850091
Depends on: 898819
Depends on: 898820
Depends on: 899857
Depends on: 900830
Depends on: 903864
Depends on: 903830
No longer depends on: 903830
All deps are gone.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Depends on: 906126
You need to log in before you can comment on or make changes to this bug.