887064 - Make the xpcshell tests independent so they can run simultaneously

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Mihnea Dobrescu-Balaur (:mihneadb)]

Right now there are tests that cannot run concurrently (for example those that use httpd with a hardcoded 8080 port).
We need to fix this in order to land the parallel xpcshell suite.

Comment 1

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: services/common/tests/unit

Comment 2

[Mihnea Dobrescu-Balaur (:mihneadb)]

Current status: https://docs.google.com/spreadsheet/ccc?key=0Au8PkXKe-IbrdFdsMFVSQWtPbmFhZlZOQ1h6ejJfTXc#gid=0

Comment 3

[Mihnea Dobrescu-Balaur (:mihneadb)]

Tests that need to be 'fixed': https://docs.google.com/document/d/1fT1JzXBwIQA5TsC185JDU-uzL1kcXbTFE9nKy0s8atw/edit

Comment 4

[Gregory Szorc [:gps]]

There needs to be some dupe action with bug 884421 or something.

Also, I recommend opening independent bugs for the larger chunks of this work under the components the tests are attached to. e.g. file an Add-on Manager bug to track updating just those tests. Add-on Manager is especially important because they are currently in the midst of a massive rewrite in bug 853388 and your test changes will likely conflict!

Finally, all these bugs should chain up to bug 660788 so we have a way to track the overall effort.

Comment 5

[Marco Bonardo [:mak]]

needinfo myself to check what's up with Places tests

Comment 6

[Marco Bonardo [:mak]]

ah there's a dependency bug, moving there

Comment 7

[Nathan Froyd [:froydnj]]

FWIW, there are quite a few tests in toolkit/ that use hardcoded ports; they tend to use port 4444.  I've started fixing them independently, though I'm not very far along.  I'll try to post some of the patches soon so we don't duplicate work.

Comment 8

[Mihnea Dobrescu-Balaur (:mihneadb)]

That's great, thank you! Do you mind creating a patch and referencing it here in the depends section?
Thanks!

Comment 9

[Mihnea Dobrescu-Balaur (:mihneadb)]

Comment on attachment 767508 [details] [diff] [review]
services/common/tests/unit

Marking this patch as obsolete since
1. a separate bug needs to be filled for this, keeping bug 887064 (this one) as a tracking bug
2. :gps has offered to help with the services/ tests.

Comment 10

[Mihnea Dobrescu-Balaur (:mihneadb)]

As discussed on IRC, for Thunderbird and Seamonkey tests we could just add the run-sequentially ini flag to the manifests' default section. Support for that flag comes with the parallel harness, in bug 887054.

Comment 11

[Mihnea Dobrescu-Balaur (:mihneadb)]

Here's a list of intermittent failures (and bugs) that I encountered so far doing try pushes with the patches applied:

indexedDB - 860714
jsdownloads - 865364
netwerk/backgroundfilesaver - 855757
devtools/dbgsocket - 775924
devtools/actor stuff - 810185
image - 867183
extensions/cookie/cookies_read - 595925, 601508, 587767
healthreporter - 850091

Comment 12

[Mihnea Dobrescu-Balaur (:mihneadb)]

All deps are gone.

Comment 13

[Matthew N. [:MattN]]

Great work. Can you please update https://developer.mozilla.org/en-US/docs/Httpd.js/HTTP_server_for_unit_tests

Comment 14

[Mihnea Dobrescu-Balaur (:mihneadb)]

https://developer.mozilla.org/en-US/docs/Httpd.js/HTTP_server_for_unit_tests
https://developer.mozilla.org/en-US/docs/Writing_xpcshell-based_unit_tests