887994 - Bring back pricetier 0 in devhub

Status: RESOLVED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P1)

Description

[krupa raj[:krupa]]

We added "free with in-app payments" and got rid of pricetier 0.

We need to bring that baby back.

Comment 1

[Andy McKay]

In the code, "Free with in-app payments" is pricetier 0. Is this just a matter of changing the text and then a collective complain that we can't have true free and paid?

Comment 2

[Wil Clouser [:clouserw]]

This is a P1 with special push priority.  If you can get it done tomorrow morning we'll do a friday push.

Comment 3

[Wil Clouser [:clouserw]]

I mid-aired with Andy.  Andy, that's interesting - paid/$0 is not the same as free w/ in-app in my mind.  Perhaps this is just a bug or misunderstanding?  Good to know they are the same though, that might get us out of a friday push.

Comment 4

[[e-mail]]

As Andy says, Free with in-app payments is price tier 0. If we shouldn't be enforcing free with in-app payments (which was dealt with in bug 884680) then we can always remove that enforcement that wouldn't be too difficult.

Other than that I'm unclear what the actual requirement is here.

Comment 5

[Andy McKay]

The problem is, that is easy to confuse "Free with in-app payments" as being "Free". Its really paid with no charge. There's:

"Free" and "$0.00". The use of in-app payments is separate and putting it in the drop down conflates two things together that don't need to be.

Perhaps the drop down should be:

http://cl.ly/image/26200Z3z3h2I

Free - sets the app premium_type to ADDON_FREE
$0.00 - sets the app premium_type to ADDON_PAID

If the in-app is selected then those premium_types become: ADDON_FREE_INAPP, ADDON_PREMIUM_INAPP

For validation we need to catch one scenario: Free and no in-app, this should not be option, that's just completely free and there's no need to be setting up payments.

I've written a Wiki page to try and be the definitive guide for all this. Please update it, otherwise we get lost in bugs.

https://wiki.mozilla.org/Marketplace/Free

Comment 6

[krupa raj[:krupa]]

Can we add "$0.00 (Promotional pricing)" which kinda explains how this pricetier is different from Free?

Comment 7

[[e-mail]]

(In reply to krupa raj[:krupa] from comment #6)
> Can we add "$0.00 (Promotional pricing)" which kinda explains how this
> pricetier is different from Free?

Yep, I'll add that to the select text.

Comment 8

[[e-mail]]

https://github.com/mozilla/zamboni/commit/1b0d9ae84b563d424638d48aefe457024948b91b