Feedback prompt needs a "Not now" option

RESOLVED FIXED in Firefox 25

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: wesj, Assigned: nickecarlo)

Tracking

Trunk
Firefox 25
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=margaret][lang=js][lang=html])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
I saw the feedback prompt run by the other day. At the top it asks "Have a minute?", but we don't provide any way for the user to say "No, I don't." The user has to realize its just a tab and open the tab strip to close it.

We should have a "Not right now" option that will close the prompt, but reset things so that it will prompt again at a later date. Or if we're not willing to take "No" for an answer, we shouldn't ask the user if its ok to pester them.

Comment 1

5 years ago
Seems reasonable to me, especially now that we got rid of the "I have an idea" section.

We already have a "Maybe Later" link in the play store review section, so the logic for this "Not Now" button could just call this maybeLater() helper function:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/aboutFeedback.xhtml#126

cc'ing ibarlow in case he wants to jump in and object :)
Blocks: 774479
Whiteboard: [mentor=margaret][lang=js][lang=html]
(Assignee)

Comment 2

5 years ago
I might want to take a stab at this. I'll take this for now but if I have no idea what I'm doing then I'll leave it for someone else.

I'll ask more specific questions here or in #mobile once I've had a chance to look at the code and the patches for 774479. :)
(Assignee)

Updated

5 years ago
Assignee: nobody → nickecarlo
(Assignee)

Comment 3

5 years ago
Links to all three images of how Maybe Later looks when added:

1: https://dl.dropboxusercontent.com/u/22352304/ugly.png

No one liked it this way.

2: https://dl.dropboxusercontent.com/u/22352304/ugly2.png

3: https://dl.dropboxusercontent.com/u/22352304/meh.png

Let me know what you guys think of 2 and 3. Or if you guys want something else entirely.

Comment 4

5 years ago
From a design perspective, I think option 3 looks the best, but if we want to encourage users to take action rather than defer, option 2 is probably better.
Flags: needinfo?(ibarlow)
I like option 3 just for consistency with the one we do for Google Play, but let's just make "later" lowercase.
Flags: needinfo?(ibarlow)
(Assignee)

Comment 6

5 years ago
Option 4:

https://dl.dropboxusercontent.com/u/22352304/feedbacklayout.png

As I was speaking with ibarlow on #mobile in this setup I moved Fennec Support stuff out of the main feedback page to "I ran into some problems" at the bottom as "You can also visit Fennec Support for more information".

This way I can place "Maybe later" at the bottom similar in style to "That's great to hear!" This looks better in terms of design and it also addresses margaret's concern about it being too much of an easy way out for the user.

Also, it looks odd that there is no heading for the "I ran into some problems" but the current layout would make it way too "crowded", I think.

If you guys like option 4 can I then just fix the "Maybe Later" to "Maybe later" on "That's great to hear!" or do you still want that as a separate patch, margaret?
Flags: needinfo?(margaret.leibovic)
Flags: needinfo?(ibarlow)
(Assignee)

Comment 7

5 years ago
Here's the "I ran into some problems" page with a header (couldn't think of anything better right now, I'll come up with something professional if you guys want it this way).

https://dl.dropboxusercontent.com/u/22352304/headeradded.png
(In reply to Nicolas Carlo [:nickecarlo] from comment #7)
> Here's the "I ran into some problems" page with a header (couldn't think of
> anything better right now, I'll come up with something professional if you
> guys want it this way).
> 
> https://dl.dropboxusercontent.com/u/22352304/headeradded.png

I would just leave the header out. Looks good otherwise.
Flags: needinfo?(ibarlow)

Comment 9

5 years ago
(In reply to Ian Barlow (:ibarlow) from comment #8)
> (In reply to Nicolas Carlo [:nickecarlo] from comment #7)
> > Here's the "I ran into some problems" page with a header (couldn't think of
> > anything better right now, I'll come up with something professional if you
> > guys want it this way).
> > 
> > https://dl.dropboxusercontent.com/u/22352304/headeradded.png
> 
> I would just leave the header out. Looks good otherwise.

+1 (sorry for the slow response here!)
Flags: needinfo?(margaret.leibovic)
(Assignee)

Comment 10

5 years ago
Created attachment 773410 [details] [diff] [review]
Patch for bug 888144

In aboutFeedback.dtd:

- Added an entity named intro.maybeLater. I chose to create a separate entity for this instead of using happy.maybeLater because they have different usage context but if you want I can change the code to use the one entity (and change its name to |maybeLater|).

- Changed the wording for the message about Fennec support since I moved it to "I ran into some problems" page.

- Corrected |Maybe Later| to |Maybe later|. I did all of this in the same patch because I was messing around the whole thing. But if you still want this as a separate patch I can do that :D

In aboutFeedback.xhtml:

- Placed the link for Maybe later.
- Moved the link for Fennec Support to "I ran into some problems" page.
Attachment #773410 - Flags: review?(margaret.leibovic)

Comment 11

5 years ago
Comment on attachment 773410 [details] [diff] [review]
Patch for bug 888144

Review of attachment 773410 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, but we need to rev the entity names before we can land this.

::: mobile/android/locales/en-US/chrome/aboutFeedback.dtd
@@ +16,5 @@
>  
>  <!-- LOCALIZATION NOTE (support.pre): Include a trailing space as needed. -->
>  <!-- LOCALIZATION NOTE (support.link): Avoid leading/trailing spaces, this text is a link. -->
>  <!-- LOCALIZATION NOTE (support.post): Include a starting space as needed. -->
> +<!ENTITY support.pre               "You can also visit ">

You'll need to update this entity name so that the l10n automation tools will know that this string changed. You could just call it support.pre2 (and update where it's used).

@@ +21,2 @@
>  <!ENTITY support.link              "&brandShortName; Support">
> +<!ENTITY support.post              " for more information.">

Same thing here.

@@ +31,5 @@
>       get people to rate us by playfully telling them there's a benefit in it for them as well. -->
>  <!ENTITY happy.finePrint           "It takes less than a minute and feels great.">
>  
>  <!ENTITY happy.ratingLink          "Yes, go to Google Play">
> +<!ENTITY happy.maybeLater          "Maybe later">

And here.
Attachment #773410 - Flags: review?(margaret.leibovic) → review-
(Assignee)

Comment 12

5 years ago
Created attachment 773504 [details] [diff] [review]
Patch for bug 888144

Updated the relevant entity names.

Sorry, should have already done it since you had mentioned something about this in chat before :D
Attachment #773410 - Attachment is obsolete: true
Attachment #773504 - Flags: review?(margaret.leibovic)

Comment 13

5 years ago
Comment on attachment 773504 [details] [diff] [review]
Patch for bug 888144

Cool, thanks for the updated patch!
Attachment #773504 - Flags: review?(margaret.leibovic) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d322561a04ce
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
Depends on: 972844
You need to log in before you can comment on or make changes to this bug.