888153 - [contacts] Import from vCard 4.0 has email missing in Contacts app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Parul Mathur]

Attachment: email address missing in import of vCard 4.0 format

Test Environment:
Device: Leo phone 
Build Identifier: 20130624070224
Update channel: leo/1.1.0/nightly
Git commit info: 2013-06-24 11:42:38 
Gaia Version: 885b874029d8143035765ae903c147a9415fcc521372074158
Gecko: 62049a1c5d36
OS version: 1.1.0.0-prerelease
Platform version: 18.1

Prerequisites:
Copy a vCard in 4.0 format on the SD Card of the phone. Ensure that the email field is filled out. (see attached vCard or see http://en.wikipedia.org/wiki/VCard)
Ensure USB storage is not enabled on the phone.

Steps to reproduce:
1. On the phone home screen, tap on the Contacts icon to launch the Contacts app.
2. In the Contacts app, tap on the gear icon at the top right to import contacts from SD Card.
3. On the Contacts Settings screen, tap on "SD Card" to start the import.
4. On the Contacts screen, tap on the imported contact.

Expected results:
The email field in the vCard 4.0 format is correctly parsed and displayed in the Contacts app.

Actual results:
The email field in the vCard 4.0 format is not displayed in the Contacts app.
(see screenshot attached)

Comment 1

[Parul Mathur]

Attachment: vCard 4.0 format

Comment 2

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

The VCF file you attached doesn't contain an Email. Am I missing something?

Comment 3

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Yes, I was missing something. My editor was truncating the text, my apologies.

Comment 4

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Attachment: Github Pull Request

Fixed vCard 4.0 parsing:

Fixed tel: prefix issues.
Improved parser, it is not based on regex anymore.
Parses several meta fields now, not only one.
Added Unit tests.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 773531 [details] [diff] [review]
Github Pull Request

r+ once small nit commented in github is solved.

Thanks a lot Sergi.

Comment 6

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Merged in fd0d621e8c1cfbc9afc9af317edb8bb03dc77ed5

Thanks Francisco!

Comment 7

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

This bug prevents vCard 4.0 from being imported properly. Some popular applications like Outlook may use this format to export contacts, and in that case, FFOS won't import them properly, thus the request for leo+.

Comment 8

[bhavana bajaj [:bajaj]]

Busted functionality for a new feature in 1.1 hence blocking

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted fd0d621e8c1cfbc9afc9af317edb8bb03dc77ed5 to:
v1-train: e89f039eba23d0cc8445d8352753d53a475ffd4b

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: e89f039eba23d0cc8445d8352753d53a475ffd4b