Make configure to detect Visual Studio 2013 compiler

RESOLVED FIXED in mozilla25

Status

()

Core
Build Config
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: Xavier Fung, Assigned: Xavier Fung)

Tracking

Trunk
mozilla25
x86
Windows 8
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
I have hacked some of the configure files to detect the compiler from Visual Studio 2013 (VC12). See if this is helpful.
(Assignee)

Comment 1

4 years ago
Created attachment 768771 [details] [diff] [review]
Patch for VS2013

Updated

4 years ago
Attachment #768771 - Flags: review?(ted)

Updated

4 years ago
Assignee: nobody → xavier114fch
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Updated

4 years ago
Blocks: 888159
Comment on attachment 768771 [details] [diff] [review]
Patch for VS2013

Review of attachment 768771 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/installer/removed-files.in
@@ +1448,5 @@
> +    msvcr120.dll
> +    #ifdef MOZ_METRO
> +      vccorlib120.dll
> +    #endif
> +  #endif  

nit: trailing whitespace

::: configure.in
@@ +500,5 @@
> +        elif test "$_CC_MAJOR_VERSION" = "18"; then
> +            _CC_SUITE=12
> +            _MSVS_VERSION=2013
> +            AC_DEFINE(_CRT_SECURE_NO_WARNINGS)
> +            AC_DEFINE(_CRT_NONSTDC_NO_WARNINGS)            

nit: trailing whitespace

While you're here, how about moving the AC_DEFINEs outside of the if blocks, since they're defined for all versions of MSVC we support now?

::: js/src/configure.in
@@ +494,5 @@
>              AC_DEFINE(_CRT_NONSTDC_NO_WARNINGS)
> +        elif test "$_CC_MAJOR_VERSION" = "18"; then
> +            _CC_SUITE=12
> +            AC_DEFINE(_CRT_SECURE_NO_WARNINGS)
> +            AC_DEFINE(_CRT_NONSTDC_NO_WARNINGS)    

same comment here as the other configure.in.
Attachment #768771 - Flags: review?(ted) → review+
Thanks for the patch!
(Assignee)

Comment 4

4 years ago
Created attachment 770291 [details] [diff] [review]
Updated patch
Attachment #768771 - Attachment is obsolete: true
https://hg.mozilla.org/integration/mozilla-inbound/rev/a52babf286bc
Target Milestone: --- → mozilla25
https://hg.mozilla.org/mozilla-central/rev/a52babf286bc
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Blocks: 914596
Duplicate of this bug: 872028
You need to log in before you can comment on or make changes to this bug.