Closed Bug 888158 Opened 7 years ago Closed 7 years ago

Make configure to detect Visual Studio 2013 compiler

Categories

(Firefox Build System :: General, defect)

x86
Windows 8
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla25

People

(Reporter: xavier114fch, Assigned: xavier114fch)

References

Details

Attachments

(1 file, 1 obsolete file)

I have hacked some of the configure files to detect the compiler from Visual Studio 2013 (VC12). See if this is helpful.
Attached patch Patch for VS2013 (obsolete) — Splinter Review
Attachment #768771 - Flags: review?(ted)
Assignee: nobody → xavier114fch
Status: UNCONFIRMED → NEW
Ever confirmed: true
Blocks: 888159
Comment on attachment 768771 [details] [diff] [review]
Patch for VS2013

Review of attachment 768771 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/installer/removed-files.in
@@ +1448,5 @@
> +    msvcr120.dll
> +    #ifdef MOZ_METRO
> +      vccorlib120.dll
> +    #endif
> +  #endif  

nit: trailing whitespace

::: configure.in
@@ +500,5 @@
> +        elif test "$_CC_MAJOR_VERSION" = "18"; then
> +            _CC_SUITE=12
> +            _MSVS_VERSION=2013
> +            AC_DEFINE(_CRT_SECURE_NO_WARNINGS)
> +            AC_DEFINE(_CRT_NONSTDC_NO_WARNINGS)            

nit: trailing whitespace

While you're here, how about moving the AC_DEFINEs outside of the if blocks, since they're defined for all versions of MSVC we support now?

::: js/src/configure.in
@@ +494,5 @@
>              AC_DEFINE(_CRT_NONSTDC_NO_WARNINGS)
> +        elif test "$_CC_MAJOR_VERSION" = "18"; then
> +            _CC_SUITE=12
> +            AC_DEFINE(_CRT_SECURE_NO_WARNINGS)
> +            AC_DEFINE(_CRT_NONSTDC_NO_WARNINGS)    

same comment here as the other configure.in.
Attachment #768771 - Flags: review?(ted) → review+
Thanks for the patch!
Attached patch Updated patchSplinter Review
Attachment #768771 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/a52babf286bc
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Blocks: VC12
Duplicate of this bug: 872028
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.