888158 - Make configure to detect Visual Studio 2013 compiler

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Xavier Fung]

I have hacked some of the configure files to detect the compiler from Visual Studio 2013 (VC12). See if this is helpful.

Comment 1

[Xavier Fung]

Attachment: Patch for VS2013

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 768771 [details] [diff] [review]
Patch for VS2013

Review of attachment 768771 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/installer/removed-files.in
@@ +1448,5 @@
> +    msvcr120.dll
> +    #ifdef MOZ_METRO
> +      vccorlib120.dll
> +    #endif
> +  #endif  

nit: trailing whitespace

::: configure.in
@@ +500,5 @@
> +        elif test "$_CC_MAJOR_VERSION" = "18"; then
> +            _CC_SUITE=12
> +            _MSVS_VERSION=2013
> +            AC_DEFINE(_CRT_SECURE_NO_WARNINGS)
> +            AC_DEFINE(_CRT_NONSTDC_NO_WARNINGS)            

nit: trailing whitespace

While you're here, how about moving the AC_DEFINEs outside of the if blocks, since they're defined for all versions of MSVC we support now?

::: js/src/configure.in
@@ +494,5 @@
>              AC_DEFINE(_CRT_NONSTDC_NO_WARNINGS)
> +        elif test "$_CC_MAJOR_VERSION" = "18"; then
> +            _CC_SUITE=12
> +            AC_DEFINE(_CRT_SECURE_NO_WARNINGS)
> +            AC_DEFINE(_CRT_NONSTDC_NO_WARNINGS)    

same comment here as the other configure.in.

Comment 3

[(not currently active) Ted Mielczarek]

Thanks for the patch!

Comment 4

[Xavier Fung]

Attachment: Updated patch

Comment 5

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a52babf286bc

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a52babf286bc