888159 - mfbt fail to compile using Visual Studio 2013

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Xavier Fung]

I am using Visual Studio 2013 Preview to build Firefox and found that mfbt cannot be built. Attached is the build log.

Comment 1

[Xavier Fung]

Attachment: Error log

Comment 2

[Makoto Kato [:m_kato]]

no mbft issue.  If using -j1 for pymake, it will resolve this.

Comment 3

[Makoto Kato [:m_kato]]

And, this issue may be a bug by preview version.

Comment 4

[Xavier Fung]

I have tried pymake and also mach build using -j1 and still got this.

c:/mozilla-inbound/mfbt/decimal/Decimal.cpp(687) : error C2039: 'isfinite' : is
not a member of 'std'
c:/mozilla-inbound/mfbt/decimal/Decimal.cpp(690) : error C2039: 'isinf' : is not
 a member of 'std'

Comment 5

[Xavier Fung]

Attachment: Patch to raise MSC version to 1800

Comment 6

[Masatoshi Kimura [:emk]]

Comment on attachment 770329 [details] [diff] [review]
Patch to raise MSC version to 1800

>-#if defined(_MSC_VER) && (_MSC_VER <= 1700)
>+#if defined(_MSC_VER) && (_MSC_VER <= 1800)

I think we should remove the version check until we actually know the MSVC version which supports these functions.

Comment 7

[Xavier Fung]

Attachment: Remove MSC version

Comment 8

[Jeff Walden [:Waldo]]

Comment on attachment 770645 [details] [diff] [review]
Remove MSC version

Review of attachment 770645 [details] [diff] [review]:
-----------------------------------------------------------------

::: mfbt/decimal/moz-decimal-utils.h
@@ +38,5 @@
>    private: \
>      ClassName(const ClassName&) MOZ_DELETE; \
>      void operator=(const ClassName&) MOZ_DELETE;
>  
> +#if defined(_MSC_VER)

Yeah, probably fair enough removing the version-check.

Comment 9

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/779c32741707

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/779c32741707