Last Comment Bug 888159 - mfbt fail to compile using Visual Studio 2013
: mfbt fail to compile using Visual Studio 2013
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86 Windows 8
: -- normal (vote)
: mozilla25
Assigned To: Xavier Fung
:
: Gregory Szorc [:gps]
Mentors:
Depends on: 888158 1007050
Blocks: VC12
  Show dependency treegraph
 
Reported: 2013-06-27 23:01 PDT by Xavier Fung
Modified: 2014-05-07 02:38 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Error log (7.58 KB, text/plain)
2013-06-27 23:02 PDT, Xavier Fung
no flags Details
Patch to raise MSC version to 1800 (900 bytes, patch)
2013-07-02 12:01 PDT, Xavier Fung
no flags Details | Diff | Splinter Review
Remove MSC version (878 bytes, patch)
2013-07-02 22:47 PDT, Xavier Fung
jwalden+bmo: review+
Details | Diff | Splinter Review

Description Xavier Fung 2013-06-27 23:01:24 PDT
I am using Visual Studio 2013 Preview to build Firefox and found that mfbt cannot be built. Attached is the build log.
Comment 1 Xavier Fung 2013-06-27 23:02:18 PDT
Created attachment 768774 [details]
Error log
Comment 2 Makoto Kato [:m_kato] 2013-07-01 21:38:07 PDT
no mbft issue.  If using -j1 for pymake, it will resolve this.
Comment 3 Makoto Kato [:m_kato] 2013-07-01 21:39:09 PDT
And, this issue may be a bug by preview version.
Comment 4 Xavier Fung 2013-07-02 11:18:24 PDT
I have tried pymake and also mach build using -j1 and still got this.

c:/mozilla-inbound/mfbt/decimal/Decimal.cpp(687) : error C2039: 'isfinite' : is
not a member of 'std'
c:/mozilla-inbound/mfbt/decimal/Decimal.cpp(690) : error C2039: 'isinf' : is not
 a member of 'std'
Comment 5 Xavier Fung 2013-07-02 12:01:21 PDT
Created attachment 770329 [details] [diff] [review]
Patch to raise MSC version to 1800
Comment 6 Masatoshi Kimura [:emk] 2013-07-02 22:30:52 PDT
Comment on attachment 770329 [details] [diff] [review]
Patch to raise MSC version to 1800

>-#if defined(_MSC_VER) && (_MSC_VER <= 1700)
>+#if defined(_MSC_VER) && (_MSC_VER <= 1800)

I think we should remove the version check until we actually know the MSVC version which supports these functions.
Comment 7 Xavier Fung 2013-07-02 22:47:54 PDT
Created attachment 770645 [details] [diff] [review]
Remove MSC version
Comment 8 Jeff Walden [:Waldo] (remove +bmo to email) 2013-07-10 16:46:30 PDT
Comment on attachment 770645 [details] [diff] [review]
Remove MSC version

Review of attachment 770645 [details] [diff] [review]:
-----------------------------------------------------------------

::: mfbt/decimal/moz-decimal-utils.h
@@ +38,5 @@
>    private: \
>      ClassName(const ClassName&) MOZ_DELETE; \
>      void operator=(const ClassName&) MOZ_DELETE;
>  
> +#if defined(_MSC_VER)

Yeah, probably fair enough removing the version-check.
Comment 10 Ed Morley [:emorley] 2013-07-11 03:01:37 PDT
https://hg.mozilla.org/mozilla-central/rev/779c32741707

Note You need to log in before you can comment on or make changes to this bug.