mfbt fail to compile using Visual Studio 2013

RESOLVED FIXED in mozilla25

Status

()

Core
Build Config
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: Xavier Fung, Assigned: Xavier Fung)

Tracking

Trunk
mozilla25
x86
Windows 8
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

4 years ago
I am using Visual Studio 2013 Preview to build Firefox and found that mfbt cannot be built. Attached is the build log.
(Assignee)

Comment 1

4 years ago
Created attachment 768774 [details]
Error log
(Assignee)

Updated

4 years ago
Depends on: 888158
no mbft issue.  If using -j1 for pymake, it will resolve this.
Component: MFBT → Build Config
And, this issue may be a bug by preview version.
(Assignee)

Comment 4

4 years ago
I have tried pymake and also mach build using -j1 and still got this.

c:/mozilla-inbound/mfbt/decimal/Decimal.cpp(687) : error C2039: 'isfinite' : is
not a member of 'std'
c:/mozilla-inbound/mfbt/decimal/Decimal.cpp(690) : error C2039: 'isinf' : is not
 a member of 'std'
(Assignee)

Comment 5

4 years ago
Created attachment 770329 [details] [diff] [review]
Patch to raise MSC version to 1800
Attachment #770329 - Flags: review?(jwalden+bmo)
Assignee: nobody → xavier114fch
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment on attachment 770329 [details] [diff] [review]
Patch to raise MSC version to 1800

>-#if defined(_MSC_VER) && (_MSC_VER <= 1700)
>+#if defined(_MSC_VER) && (_MSC_VER <= 1800)

I think we should remove the version check until we actually know the MSVC version which supports these functions.
(Assignee)

Comment 7

4 years ago
Created attachment 770645 [details] [diff] [review]
Remove MSC version
Attachment #770329 - Attachment is obsolete: true
Attachment #770329 - Flags: review?(jwalden+bmo)
Attachment #770645 - Flags: review?(jwalden+bmo)
Comment on attachment 770645 [details] [diff] [review]
Remove MSC version

Review of attachment 770645 [details] [diff] [review]:
-----------------------------------------------------------------

::: mfbt/decimal/moz-decimal-utils.h
@@ +38,5 @@
>    private: \
>      ClassName(const ClassName&) MOZ_DELETE; \
>      void operator=(const ClassName&) MOZ_DELETE;
>  
> +#if defined(_MSC_VER)

Yeah, probably fair enough removing the version-check.
Attachment #770645 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/779c32741707
Target Milestone: --- → mozilla25
https://hg.mozilla.org/mozilla-central/rev/779c32741707
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Blocks: 914596
Depends on: 1007050
You need to log in before you can comment on or make changes to this bug.