clickable links in Help | About not shown in highlighted text for Daily and Earlybird.

RESOLVED FIXED in Thunderbird 25.0

Status

Thunderbird
Mail Window Front End
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: wsmwk, Assigned: Paenglab)

Tracking

Trunk
Thunderbird 25.0
x86
Windows Vista

Thunderbird Tracking Flags

(thunderbird24 fixed)

Details

Attachments

(4 attachments)

Created attachment 768872 [details]
screen shots of Help | About for TB22 beta and TB23 Earlybird

The clickable links in Help | About not shown in highlighted text for Daily and Earlybird. Thus, users are going to miss our hints there, such as "get involved".  

Looks OK for the TB22 beta. BUT is/will TB23 beta OK?
(Assignee)

Comment 1

4 years ago
Firefox is also using white links and white text. There should be also filed a bug for Firefox.

Or maybe it's by design. People using Daily and Aurora don't need this links as they are already involved in testing?
(Assignee)

Comment 2

4 years ago
Created attachment 768892 [details]
About on Aurora

Blake, what do you think about black as link color? Blue on this blue background wouldn't be optimal.

Don't be irritated, this screenshot is made on Daily with the Aurora background.
Attachment #768892 - Flags: ui-review?(bwinton)
(Assignee)

Comment 3

4 years ago
Created attachment 768893 [details]
About on Daily

On Daily #00f would be optimal, I think.
Attachment #768893 - Flags: ui-review?(bwinton)
(In reply to Richard Marti [:Paenglab] from comment #1)
> Firefox is also using white links and white text. There should be also filed
> a bug for Firefox.

ah. quite right

> People using Daily and Aurora don't need this links as they are already involved in testing?

I would disagree. I don't think we can assume they are giving us feedback or there for the purposes of "testing". In addition, the size of our testing population isn't so high that we can't afford to assume we "have them".
(In reply to Richard Marti [:Paenglab] from comment #3)
> Created attachment 768893 [details]
> About on Daily
> 
> On Daily #00f would be optimal, I think.

FWIW, I like it. Although "get involved" also needs the modification for both channels.  

Is this skin ever affected by user OS theme preferences?
(Assignee)

Comment 6

4 years ago
(In reply to Wayne Mery (:wsmwk) from comment #5)
> (In reply to Richard Marti [:Paenglab] from comment #3)
> > Created attachment 768893 [details]
> > About on Daily
> 
> FWIW, I like it. Although "get involved" also needs the modification for
> both channels.  

I know, this was only a fast DOMi tweak to show how it could look.

> Is this skin ever affected by user OS theme preferences?

As I see it, the colors are hard coded in the branding files and are looking on all OS themes the same.
Comment on attachment 768892 [details]
About on Aurora

Yeah, it's not the best, but I'ld buy it.
(I think a very dark blue might also work, if you wanted to try that option and go with whatever feels better to you.)
Attachment #768892 - Flags: ui-review?(bwinton) → ui-review+
Comment on attachment 768893 [details]
About on Daily

And yeah, this blue is nicely contrasting with that orange.  I think we could go even a little lighter, if you wanted…
Attachment #768893 - Flags: ui-review?(bwinton) → ui-review+
(Assignee)

Comment 9

4 years ago
Created attachment 769082 [details] [diff] [review]
patch

On Aurora the links are now a dark blue. And on Daily the link is a slightly lighter blue than on the screenshot.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #769082 - Flags: ui-review?(bwinton)
Attachment #769082 - Flags: review?(bwinton)
Comment on attachment 769082 [details] [diff] [review]
patch

Carrying forward the ui-r=me from the previous screenshots, and the code looks good, so r=me while we're here.
Attachment #769082 - Flags: ui-review?(bwinton)
Attachment #769082 - Flags: ui-review+
Attachment #769082 - Flags: review?(bwinton)
Attachment #769082 - Flags: review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
(Assignee)

Comment 11

4 years ago
Comment on attachment 769082 [details] [diff] [review]
patch

[Approval Request Comment]
User impact if declined: User can not determine where is a link.
Risk to taking this patch (and alternatives if risky): Low, this are only color changes.
Attachment #769082 - Flags: approval-comm-aurora?
https://hg.mozilla.org/comm-central/rev/d91cc1d91c8b
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 25.0
Comment on attachment 769082 [details] [diff] [review]
patch

a=Standard8
Attachment #769082 - Flags: approval-comm-aurora? → approval-comm-aurora+
https://hg.mozilla.org/releases/comm-aurora/rev/121851d0d988
status-thunderbird24: --- → fixed
You need to log in before you can comment on or make changes to this bug.