Closed Bug 888335 Opened 7 years ago Closed 6 years ago

Remove support for iGoogle/Reader from feed subscriptions

Categories

(Firefox for Android :: General, defect)

x86_64
Linux
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 26
Tracking Status
firefox24 --- wontfix
firefox25 --- verified
firefox26 --- verified
fennec 24+ ---

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(2 files)

Reader is dead on July 1 2013 and iGoogle looks to be killed on Nov 1 2013.
Reader is dead.
23+ ship has sailed. Need to re-triage this.
tracking-fennec: 23+ → ?
tracking-fennec: ? → 24+
Assignee: nobody → mark.finkle
Status: NEW → ASSIGNED
* Removes the built-in support for google reader
* Fixes a trailing comma warning (I'm not a lover of trailing commas anyway)
* Fixes 4 space indent to 2 space on a function block
Attachment #800539 - Flags: review?(bnicholson)
Attachment #800539 - Flags: review?(bnicholson) → review+
Land for upcoming re-spin?
[Approval Request Comment]
Bug caused by (feature/regressing bug #): None
User impact if declined: Possibly offer to send an RSS feed to a non-existent Google service
Testing completed (on m-c, etc.): none
Risk to taking this patch (and alternatives if risky): low - removing some prefs
String or IDL/UUID changes made by this patch: none
Attachment #802512 - Flags: review?(bnicholson)
Attachment #802512 - Flags: approval-mozilla-beta?
Attachment #802512 - Flags: approval-mozilla-aurora?
Comment on attachment 802512 [details] [diff] [review]
Simple aurora and beta patch

Looks OK to me, but I'm not familiar enough with l10n policies to know whether this counts as a string removal. Axel, can you take a look?
Attachment #802512 - Flags: review?(bnicholson) → review?(l10n)
Comment on attachment 802512 [details] [diff] [review]
Simple aurora and beta patch

Review of attachment 802512 [details] [diff] [review]:
-----------------------------------------------------------------

This counts as string removal, but we're removing google reader in l10n already as part of bug 906688, so this is cool.

Mind sending a note to mozilla.dev.l10n and reference the l10n bug 906688?
Attachment #802512 - Flags: review?(l10n) → review+
Comment on attachment 802512 [details] [diff] [review]
Simple aurora and beta patch

Looks ok to land on Aurora.

Its not the end of the world if a few users try to subscribe to a feed with google reader and do not succeed rather than take anything unnecessary and absolutely critical at this point in the Fx24 cycle .

Unless we are getting major feedback from users that this is a bothering issue I would like to leave it in the same state as Fx23 for now.Please renom with reasoning if needed.
Attachment #802512 - Flags: approval-mozilla-beta?
Attachment #802512 - Flags: approval-mozilla-beta-
Attachment #802512 - Flags: approval-mozilla-aurora?
Attachment #802512 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/0f03efa6263d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Verified fixed on:
Build: Firefox for Android 25.0b1 (2013-09-18)
Device: LG Nexus 4
OS: Android 4.2.2
Verified fixed on:
Build: Firefox for Android 26.0a2 (2013-09-18)
Device: Samsung Galaxy R
OS: Android 2.3
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.