888335 - Remove support for iGoogle/Reader from feed subscriptions

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Reader is dead on July 1 2013 and iGoogle looks to be killed on Nov 1 2013.

Comment 1

[Aaron Train [:aaronmt]]

Reader is dead.

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

23+ ship has sailed. Need to re-triage this.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: remove-google-reader

* Removes the built-in support for google reader
* Fixes a trailing comma warning (I'm not a lover of trailing commas anyway)
* Fixes 4 space indent to 2 space on a function block

Comment 4

[Aaron Train [:aaronmt]]

Land for upcoming re-spin?

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: Simple aurora and beta patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): None
User impact if declined: Possibly offer to send an RSS feed to a non-existent Google service
Testing completed (on m-c, etc.): none
Risk to taking this patch (and alternatives if risky): low - removing some prefs
String or IDL/UUID changes made by this patch: none

Comment 6

[Brian Nicholson (:bnicholson)]

Comment on attachment 802512 [details] [diff] [review]
Simple aurora and beta patch

Looks OK to me, but I'm not familiar enough with l10n policies to know whether this counts as a string removal. Axel, can you take a look?

Comment 7

[Axel Hecht [:Pike]]

Comment on attachment 802512 [details] [diff] [review]
Simple aurora and beta patch

Review of attachment 802512 [details] [diff] [review]:
-----------------------------------------------------------------

This counts as string removal, but we're removing google reader in l10n already as part of bug 906688, so this is cool.

Mind sending a note to mozilla.dev.l10n and reference the l10n bug 906688?

Comment 8

[bhavana bajaj [:bajaj]]

Comment on attachment 802512 [details] [diff] [review]
Simple aurora and beta patch

Looks ok to land on Aurora.

Its not the end of the world if a few users try to subscribe to a feed with google reader and do not succeed rather than take anything unnecessary and absolutely critical at this point in the Fx24 cycle .

Unless we are getting major feedback from users that this is a bothering issue I would like to leave it in the same state as Fx23 for now.Please renom with reasoning if needed.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0f03efa6263d

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0f03efa6263d

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f53ed314d01f

Comment 12

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
Build: Firefox for Android 25.0b1 (2013-09-18)
Device: LG Nexus 4
OS: Android 4.2.2

Comment 13

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
Build: Firefox for Android 26.0a2 (2013-09-18)
Device: Samsung Galaxy R
OS: Android 2.3