888380 - Alert service notifications shouldn't disappear when hovered

Status: RESOLVED FIXED

(Toolkit Graveyard :: Notifications and Alerts, enhancement)

Description

[Chris McGee]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:22.0) Gecko/20100101 Firefox/22.0 (Beta/Release)
Build ID: 20130620135945

Steps to reproduce:

Install an add-on that makes use of the add-on sdk notifications API.
Trigger some action that causes a notification to occur.


Actual results:

The notification shows up in a new style from Firefox 21. They disappear too quickly for me to read them fully.


Expected results:

The notifications would ideally show up using the native Linux desktop notification system and stay visible for a little longer than they do now. When I hover over them with my mouse they would remain there until I move my mouse or click on them.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I was under the impression that the SDK notifications just use Firefox's built-in notification API starting in Firefox 22, right Irakli?

Comment 2

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

SDK was always using a firefox's built-in notification API. Firefox has switched notifications back-end so I'd just forward all such bugs to firefox notifications.

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Moving to Firefox, in that case.

Comment 4

[Matthew N. [:MattN]]

(In reply to Chris McGee from comment #0)
> The notifications would ideally show up using the native Linux desktop
> notification system and stay visible for a little longer than they do now.

Bug 858919 covers libnotify integration and bug  

> When I hover over them with my mouse they would remain there until I move my
> mouse or click on them.

I'm morphing this bug to cover this enhancement which I don't see an existing bug on.

Comment 5

[Matthew N. [:MattN]]

Attachment: v.1 Pause the CSS animation on :hover

Growl on OS X does this and comment 0 says at least some type of Linux notifications do this.

It's especially bad without this patch when a notification disappears from under your mouse when trying to click on it.

Comment 6

[Matthew N. [:MattN]]

Comment on attachment 798261 [details] [diff] [review]
v.1 Pause the CSS animation on :hover

I forgot to mention that I manually tested this on 10.7, Windows 7, and Fedora 18.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 798261 [details] [diff] [review]
v.1 Pause the CSS animation on :hover

Review of attachment 798261 [details] [diff] [review]:
-----------------------------------------------------------------

This is great! Can we also force opacity:1 when it is hovered?

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch v.11

Setting opacity:1 doesn't get applied but it does work when !important is used. I tested this out by making the fade out start at 50% of the animation duration.

Comment 9

[Matthew N. [:MattN]]

Comment on attachment 800896 [details] [diff] [review]
Patch v.11

It seems like the opacity change should go in the theme files with the others. Would that also avoid the !important? I'll just land my patch for now and we can handle opacity in a follow-up since it's a small edge-case to hover during the short opacity animation.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/51d151978c2b

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/51d151978c2b