888382 - 'Choose what I share' text link must be blue

Status: VERIFIED WORKSFORME

(Firefox Health Report Graveyard :: Web: Health Report, defect)

Description

[Arun Balachandran Ganesan [:abc]]

The 'Choose what I share' link at the bottom of the page in about:health report on Android has to be blue to indicate that it's a link. It links to Settings > Firefox Health Report.

Comment 1

[Matt Brandt [:mbrandt]]

Attachment: qa - screenshot fhr-dev

Bumping to invalid - the fix was landed on fhr-dev earlier this week by espressive \o/ UX goodness coming to prod soon!

Android 4.0.4
set datareporting.healthreport.about.reportUrl = https://fhr-dev.allizom.org/en-US/

Comment 3

[Daniel Holbert [:dholbert]]

(In reply to Matt Brandt [:mbrandt] from comment #1)
> Bumping to invalid - the fix was landed on fhr-dev earlier this week by
> espressive \o/ UX goodness coming to prod soon!

That means this is WORKSFORME, not INVALID.

Comment 4

[Matt Brandt [:mbrandt]]

(In reply to Daniel Holbert [:dholbert] from comment #3)
> (In reply to Matt Brandt [:mbrandt] from comment #1)
> > Bumping to invalid - the fix was landed on fhr-dev earlier this week by
> > espressive \o/ UX goodness coming to prod soon!
> 
> That means this is WORKSFORME, not INVALID.
Bumping to QA verified wfm:

Fair enough -- my rational was that the bug was invalid because in theory the patch already existed on fhr-dev, previous to the bug being filed. Thus an invalid bug.

Comment 5

[Daniel Holbert [:dholbert]]

(For future reference -- per https://bugzilla.mozilla.org/page.cgi?id=fields.html#status, INVALID means "The problem described is not a bug", which basically means "the behavior that the reporter thinks is buggy is actually the correct behavior". And that's not the case here)

(In reply to Matt Brandt [:mbrandt] from comment #4)
> Fair enough -- my rational was that the bug was invalid because in theory
> the patch already existed on fhr-dev, previous to the bug being filed. Thus
> an invalid bug.

Sure -- in Gecko-land, this happens all the time -- we fix a bug on trunk, meanwhile users on Aurora/Beta may get bitten by it because the fix hasn't made it there yet, so they may file a bug report on it, unaware that it's been fixed.

We don't resolve those as INVALID - when possible, we dupe those bugs to the bug w/ the fix, or (if we don't know which bug has the fix) we resolve them as WFM to indicate "it works now, but we don't know what fixed it".

Comment 6

[Matt Brandt [:mbrandt]]

Beauty .. thanks :dholbert! much appreciated. I'll be more prescient next time.