Closed Bug 888550 Opened 7 years ago Closed 7 years ago

use a dynamic port in search/ xpcshell tests so they can be run in parallel

Categories

(Firefox :: Search, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 25

People

(Reporter: mihneadb, Assigned: mihneadb)

References

Details

Attachments

(1 file, 3 obsolete files)

No description provided.
Attached patch use -1 as httpd port (obsolete) — Splinter Review
Assignee: nobody → mihneadb
Blocks: 887064
Attachment #769287 - Flags: review?(mnoorenberghe+bmo)
Comment on attachment 769287 [details] [diff] [review]
use -1 as httpd port

Review of attachment 769287 [details] [diff] [review]:
-----------------------------------------------------------------

Nit: it wouldn't hurt to use a local variable for |"http://localhost:" + httpServer.identity.primaryPort| in some cases when it's duplicated more than two times nearby. It makes the code more readable IMO and leads to shorter lines.

r=me with nits. Thanks.

::: toolkit/components/search/tests/xpcshell/test_addEngine_callback.js
@@ +111,5 @@
>                              Ci.nsISearchEngine.DATA_XML,
>                              null, false, searchCallback);
>  });
>  
> +let httpServer;

Nit: I think this would be better at the top of the file under the |const|. 
Add a "g" prefix (e.g. gHttpServer) to indicate it's a global like we do with gProfD.
Attachment #769287 - Flags: review?(mnoorenberghe+bmo) → review+
Status: NEW → ASSIGNED
Component: General → Search
OS: Linux → All
Product: Toolkit → Firefox
Hardware: x86_64 → All
Attached patch use -1 as httpd port (obsolete) — Splinter Review
Updated. Keeping r+.
Attachment #769287 - Attachment is obsolete: true
Attachment #772508 - Flags: review+
Attached patch use -1 as httpd port (obsolete) — Splinter Review
Added commit message.
Attachment #772508 - Attachment is obsolete: true
Attachment #772736 - Flags: review+
Comment on attachment 772752 [details] [diff] [review]
use -1 as httpd.js port

added commit metadata
Attachment #772752 - Flags: review+
Attachment #772736 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/82afb38d2b14
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
You need to log in before you can comment on or make changes to this bug.