888550 - use a dynamic port in search/ xpcshell tests so they can be run in parallel

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Comment 1

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: use -1 as httpd port

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 769287 [details] [diff] [review]
use -1 as httpd port

Review of attachment 769287 [details] [diff] [review]:
-----------------------------------------------------------------

Nit: it wouldn't hurt to use a local variable for |"http://localhost:" + httpServer.identity.primaryPort| in some cases when it's duplicated more than two times nearby. It makes the code more readable IMO and leads to shorter lines.

r=me with nits. Thanks.

::: toolkit/components/search/tests/xpcshell/test_addEngine_callback.js
@@ +111,5 @@
>                              Ci.nsISearchEngine.DATA_XML,
>                              null, false, searchCallback);
>  });
>  
> +let httpServer;

Nit: I think this would be better at the top of the file under the |const|. 
Add a "g" prefix (e.g. gHttpServer) to indicate it's a global like we do with gProfD.

Comment 3

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: use -1 as httpd port

Updated. Keeping r+.

Comment 4

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: use -1 as httpd port

Added commit message.

Comment 5

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: use -1 as httpd.js port

Comment 6

[Mihnea Dobrescu-Balaur (:mihneadb)]

Comment on attachment 772752 [details] [diff] [review]
use -1 as httpd.js port

added commit metadata

Comment 7

[Mihnea Dobrescu-Balaur (:mihneadb)]

try run https://tbpl.mozilla.org/?tree=Try&rev=6a14be4c881c

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/82afb38d2b14

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/82afb38d2b14