888567 - Bookmark star icon doesn't work properly on link-opened tab

Status: RESOLVED DUPLICATE of bug 974406

(Toolkit :: Places, defect)

Description

[Kyle Simpson]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:23.0) Gecko/20130624 Firefox/23.0 (Nightly/Aurora)
Build ID: 20130624004020

Steps to reproduce:

I click a link to open a new tab, then click the bookmark star to create a bookmark.


Actual results:

The star flashes blue for a split second, then goes back to empty. repeated clicks of the star do the same. Makes it seem that it wasn't bookmarked, but if you close that tab then re-open to that same URL, the blue star is there, so it was in fact bookmarked. And now the blue star can be clicked again to bring up the bookmark option dialog, where you can remove it. However, if you then try to click the star again to re-bookmark, it still is misbehaving as described.

Here's a screencast showing the bug happen:

https://vimeo.com/69361456

As shown in the screencast, it does work correctly if you manually open a tab and paste in a URL, or otherwise navigate to some URL. It only appears to malfunction when a tab was opened by clicking a link in a previous tab, or when a tab was opened by clicking a link in an external program.


Expected results:

I of course would expect the blue star to appear and stay.

Comment 1

[Alice0775 White]

Steps to reproduce
1. Open http://github.com/ (no need logged in)
2. Click Star UI


Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/afc1125f9c14
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120224 Firefox/13.0a1 ID:20120224052030
Bad:
http://hg.mozilla.org/mozilla-central/rev/58dd942011a8
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120224 Firefox/13.0a1 ID:20120224092148
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=afc1125f9c14&tochange=58dd942011a8

Regression window(m-c)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/154d6f29dfb9
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120224 Firefox/13.0a1 ID:20120224022630
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/e2ee770cc461
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120224 Firefox/13.0a1 ID:20120224041330
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=154d6f29dfb9&tochange=e2ee770cc461

Regressed by:
a9a8c57be783	Marco Bonardo — Bug 728230 - Enforce copying non-primitive properties in Places transactions to avoid runtime leaks. r=dietrich

Comment 2

[Alice0775 White]

The problem happens when the URL redirected http to https.

Example site:
http://bugzilla.mozilla.org/
http://github.com/

Comment 3

[Alice0775 White]

Menu > 
Bookmarks > Bookmark This Page  Ctrl+D
Bookmarks > Bookmark All Tabs… Ctrl+Shift+D
are also broken.

Comment 4

[Kyle Simpson]

This seems to have been resolved. My bookmark star icons work great now.

Comment 5

[Alice0775 White]

I can still reproduce the problem with STR of comment#1

http://hg.mozilla.org/mozilla-central/rev/a8daa428ccbc
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130815030203

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

(In reply to Alice0775 White from comment #2)
> The problem happens when the URL redirected http to https.
> 
> Example site:
> http://bugzilla.mozilla.org/
> http://github.com/

It's already been shipped for a long time - we should get a fix and nominate for uplift if low-risk, but not a release blocker.

Marco can you take a look and see if there's an obvious solution here?  It probably doesn't hit our users too often but it's certainly a less-than-ideal user experience.

Comment 8

[Marco Bonardo [:mak]]

after investigating bug 974406 I think I have some good suspects for this bug

Comment 9

[Marco Bonardo [:mak]]

the patch in bug 974406 should also fix this one, they are basically the same so I'm duping this there since there is a patch.