Closed
Bug 888570
Opened 12 years ago
Closed 12 years ago
Lazily load ForgetAboutSite.jsm from browser/components/places/content/controller.js
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: MattN, Assigned: MattN)
Details
(Whiteboard: [MemShrink])
Attachments
(1 file)
|
1.34 KB,
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
Only one of the context menu items uses this but it's currently initialized during startup. I verified using the BrowserDebugger that the JSM is no longer loaded on startup after making this lazy.
Try push: https://tbpl.mozilla.org/?tree=Try&rev=4b952c06aaa7
Attachment #769325 -
Flags: review?(jaws)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 769325 [details] [diff] [review]
v.1 Use XPCOMUtils.defineLazyModuleGetter
Review of attachment 769325 [details] [diff] [review]:
-----------------------------------------------------------------
Nice!
Attachment #769325 -
Flags: review?(jaws) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
Try push: https://tbpl.mozilla.org/?tree=Try&rev=aa80ce3adf47
https://hg.mozilla.org/integration/mozilla-inbound/rev/70488f55e30d
Flags: in-testsuite-
|
||
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•