Closed
Bug 888585
Opened 11 years ago
Closed 11 years ago
Only load LightweightThemeImageOptimizer if there is an actual lightweight theme applied
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: jaws, Assigned: jaws)
Details
(Whiteboard: [Memshrink])
Attachments
(1 file)
|
1.31 KB,
patch
|
MattN
:
review+
|
Details | Diff | Splinter Review |
LightweightThemeImageOptimizer is loaded at start-up even when a lightweight theme isn't applied. This is because LightweightThemeConsumer.jsm is calling optimize() on a dummy object, in which case LightweightThemeImageOptimizer just returns immediately. Only calling optimize() when necessary results in us not loading LightweightThemeImageOptimizer. Lightweight themes still apply correctly and get optimized correctly. Also verified that it is no longer loaded at start-up using the Browser Debugger.
Attachment #769346 -
Flags: review?(mnoorenberghe+bmo)
|
||
Updated•11 years ago
|
Attachment #769346 -
Flags: review?(mnoorenberghe+bmo) → review+
|
Assignee | |
Comment 1•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2485e9b9c19f
|
||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2485e9b9c19f
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•