888818 - [Settings] missing localization of default media location popup

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Leo]

1. Title : missing localization of default media location popup 
2. Precondition : 
3. Tester's Action : Settings - Media storage - Default media location - click select box
4. Detailed Symptom : Do not translate
5. Expected : Display the string of popup as selected language
6. Reproducibility: Y
   - Frequency Rate : 100%
7.Gaia Master/v1-train : Reproduced
8. Version Info
Build ID : 20130616070209
GAIA : f2d6ed54a236e6e3b94f0abad9f0dacb8a1cc7b3
GECKO : be276cf55ce160bca09f36d9ca679a2ae20ea7cc

Comment 1

[Leo]

Attachment: patch

Comment 2

[Fabien Cazenave [:kaze]]

Good catch, thanks! Merged on master:
https://github.com/mozilla-b2g/gaia/commit/7b2c7297ca5b09830d986a04e9b682e151173ad2

Comment 3

[Gareth Aye [:gaye] (back from PTO)]

Uplifted 7b2c7297ca5b09830d986a04e9b682e151173ad2 to:
v1-train: 1629f1b9885a7024e9edfe96a003ed3742b41dbb

Comment 4

[Gareth Aye [:gaye] (back from PTO)]

v1.1.0hd: 1629f1b9885a7024e9edfe96a003ed3742b41dbb

Comment 5

[Deepa Subramanian]

The popup banner appears in the language selected (tested on French, Greek, Spanish, German, Cestina, Hrvatski and Hunagarian). 

The buttons found on the popup banner is in English and there is a bug https://bugzilla.mozilla.org/show_bug.cgi?id=892788.

-Environmental Variables-
Leo Build ID: 20130717070237
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/582e3a7018b0
Gaia: c506c50adaaebcf729ac3c27887ba2931ab79040
Platform Version: 18.1

Comment 6

[Deepa Subramanian]

Attachment: Screenshot

Comment 7

[Chris Kreinbring [:CKreinbring]]

On a repro attempt on Leo 1.1 mozilla RIL, the warning text and the Internal/SD Card options are untranslated in the Arabic and Turkish languages.

Build ID: 20130725070209
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/142cb317a178
Gaia: b1945e7eca58c9176d91998390871864f5e8eb3e
Platform Version: 18.1

Comment 8

[Fabien Cazenave [:kaze]]

(In reply to ckreinbring from comment #7)
> On a repro attempt on Leo 1.1 mozilla RIL, the warning text and the
> Internal/SD Card options are untranslated in the Arabic and Turkish
> languages.

The Arabic locale is not a v1.1 target.
The Turkish locale is not 100% ready yet (the related string is untranslated), but that’s not a Gaia issue. Please open a separate bug for that and ping Pike ([e-mail]).

I confirm it works for other locales (e.g. French, Spanish…).

Comment 9

[sarsenyev]

As per comment 5 and 8, all locales are localized except for Arabic and Turkish
A new bug is created for Turkish language

https://bugzilla.mozilla.org/show_bug.cgi?id=899771

Environmental  Variables:
Build ID: 20130730070228
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/1fe3339e3d96
Gaia: 6221737cb50d6e8435ac5d3fe3b7e2788bd8a37c
Platform Version: 18.1

Comment 10

[sarsenyev]

Verified on Leo MOZ RIL V1.1
Turkish are localized in warning message, when "changing media location"

Environmental  Variables:
Build ID: 20130805071207
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/a2a9b89ef5ee
Gaia: 45f6a739b09292e16717fb21003386c914ca29c2
Platform Version: 18.1

Comment 11

[Fabien Cazenave [:kaze]]

Comment on attachment 769588 [details]
patch

Forgot to r+ before merging…