888831 - Developer reporting unable to save privacy policy info

Status: RESOLVED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P1)

Description

[Lisa Brewster [:adora]]

From the developer:  "I placed a link in the 'Privacy Policy' (http://willicab.com.ve/apps/firefeed/privacy-policy.php) but is still listed as none when saved."

No privacy policy section is even listed on the app's history page:  https://marketplace.firefox.com/reviewers/apps/review/firefeed

Comment 1

[Wil Clouser [:clouserw]]

cvan suspects this is because we're saving in their default language and not English.  In AMO we let people choose their language in the submission flow but in the marketplace we don't so that leads to complications.  This may be saved in another locale, or it may be not saved because we didn't support his language.  Might be a dupe of 804980.

Lisa: do you know what language they were using the site in?

Comment 2

[Mathieu Pillard [:mat]]

It looks like it was saved in es, in the db we have a translation for this field in "es" containing this link. Not in english.

Interestingly, the user lang is en-US in the db (but he might have used a different lang when submitting). And the app default locale is "es".

Comment 3

[Mathieu Pillard [:mat]]

More investigating: I think this might be 2 or 3 different bugs, although they are closely related so
it might be the same core problem. Here is what I did:

- Took the app manifest and submitted it locally. Its default_locale is 'es', 
  and it includes an 'en-US' and an 'es' verison of its description.

- With the developers pages UI in 'fr' (either because of my user or my 
  Accept-Language, I didn't check) I started filling up the details form, 
  including privacy policy and description.

- I finished submitting and here is what I have in the database:
  - For the description and support email, 2 Translation objects, one in 'en-US'
    and one in 'es'. The 'en-US' one is straight from the manifest, and the 'es'
    one is the one I modified when submitting the details.

  - For the privacy policy, 2 Translation objects, one in 'fr' and one in 'es'.
    The french one is empty, and the one in 'es' is the one I entered when 
    submitting the details.

When revisiting the app details page in the devhub, with "Localize for: Español" 
(the default), it correctly picks the spanish description and support email
(and it says it's in Español), but for the privacy policy it picks up the french,
empty one (and it doesn't specify the language, since it's the same as the UI)

If I add a ?lang=en-US, to the app details page, everything correctly falls back
to the 'es' version.


The bugs / unexpected behavior are:
- Why does it use the app's default_locale instead of your current one during the initial submit? At the very least if it's intended we should warn the user about this, it's confusing.
- Why did it create an empty 'fr' version of the privacy policy when submitting
- Why did it pick that empty 'fr' version of the privacy policy when showing 
  the edit page, since there is already an 'es' one. I was using the 'fr' locale,
  but I asked to show the "Español" localization, it should do it for the whole
  app.

Comment 4

[Mathieu Pillard [:mat]]

Another note: for the second problem - the fact that my current locale is used to show some of the app info instead of the app's default locale, it's worth noting that when you switch to edit mode, the app's default locale is correctly used instead.

Comment 6

[Mathieu Pillard [:mat]]

Pull request for the third (and not second like my previous comment says) issue is submitted:  https://github.com/mozilla/zamboni/pull/882

Comment 7

[Andrew Williamson [:eviljeff]]

Another developer was unable to update his description (otherwise same symptoms).  Does this sound like the same issue (that your pull will fix?)

Comment 8

[Mathieu Pillard [:mat]]

In the edit page, developers weren't be able to see the translated values for some fields (privacy_policy, support_url, homepage) even though we saved them correctly in the language selected on the page (*). That's what my pull request fixes.


(*) If you look at the app mentioned in the first comment for instance, we did correctly save the privacy policy, it's just that it never shows up for the developer in the edit page :(

Comment 9

[Christopher Van Wiemeersch [:cvan]]

I bet you this was related to bug 800341

Comment 10

[Andrew Williamson [:eviljeff]]

(In reply to Christopher Van Wiemeersch [:cvan] from comment #9)
> I bet you this was related to bug 800341

hmm... but it /was/ saving for me.

Comment 11

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/f00bc34dced8540235fc50ee4ae7e050cf9d739f


It's a bit tricky to reproduce because there are multiple problems colliding in various situations. Bear with me:

- Upload an app with some locales, but NOT the one you are currently using the site in. I used http://dugong3515.testmanifest.com/ , which has translations for its description in "es" and "en-US", and used the marketplace in "fr" for the whole thing. The following steps assume you did the same.

- Go to the edit page, when selecting "Localize for <lang>"/"Traduire en : <lang>" , you should see the Description and Privacy Policy (among others) change according to the language

- The default lang should be Español, French should have an empty Privacy Policy (it's a bug, but another one).

- Test then that when Español is selected, editing the privacy policy and description both work. Reload the page to make sure.

- Re-test also with localize for set to French.


TL;DR: if you have an empty field in one locale, it shouldn't prevent you to edit it and see the results in that locale or any other.