888841 - [helix] Need to set GAIA_DEV_PIXELS_PER_PX=1.5 for Gaia build process specifically for this device

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I believe I should add that somewhere in

https://github.com/mozilla-b2g/device-helix ?

Please help.

Comment 1

[Marco Chen [:mchen]]

Attachment: Part1 - To add a variable for gaia scaling value in full_helix.mk

Comment 2

[Marco Chen [:mchen]]

Attachment: Part 2: To check and assign definition from full_helix.mk

Hi :mwu,

From the request from gaia side, currently gaia needs to specify the scale value manually or gaia can't choose the correct image with correct resolution. So I add related definition into full_helix.mk and map to Android.mk of gaia.

Thanks.

Comment 3

[Michael Wu [:mwu]]

Comment on attachment 769612 [details] [diff] [review]
Part1 - To add a variable for gaia scaling value in full_helix.mk

Review of attachment 769612 [details] [diff] [review]:
-----------------------------------------------------------------

Approach looks fine. Not sure if the variable name is good, but I think you can debate that with whomever is reviewing the gaia side.

Comment 4

[Michael Wu [:mwu]]

Comment on attachment 769625 [details] [diff] [review]
Part 2: To check and assign definition from full_helix.mk

Looks ok to me, though I don't think there should be a space after the comma on the ifneq line.

Comment 5

[Marco Chen [:mchen]]

Attachment: Part 2, v2: To check and assign definition from full_helix.mk

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 769993 [details] [diff] [review]
Part 2, v2: To check and assign definition from full_helix.mk

Looks alright, but can we NOT invent another variable "GAIA_DEFAULT_SCALE_VALUE"?

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 769993 [details] [diff] [review]
Part 2, v2: To check and assign definition from full_helix.mk

Looks like :mwu have already agreed with me on comment 3. Let's use the orignal variable name instead of GAIA_DEFAULT_SCALE_VALUE.

Comment 8

[Marco Chen [:mchen]]

Attachment: Part1 v2 - To add a variable for gaia scaling value in full_helix.mk

Change the definition name to GAIA_DEV_PIXELS_PER_PX (the same name in Gaia).

Comment 9

[Marco Chen [:mchen]]

Attachment: Part2, v3: To check and assign definition from full_helix.mk in Gaia's Android.mk

Change the definition name to GAIA_DEV_PIXELS_PER_PX (the same name in Gaia).

Comment 10

[Wayne Chang [:wchang]]

HD+ing as required

Comment 11

[Marco Chen [:mchen]]

Hi Michael,

Could you help to review the patch of part 1?
Which had got the feedback+ from you and change the definition name align with Gaia side.

Thanks.

Comment 12

[Michael Wu [:mwu]]

Comment on attachment 770060 [details] [diff] [review]
Part1 v2 - To add a variable for gaia scaling value in full_helix.mk

r=me for this and any other similar fixes we need for other devices like Nexus 4.

Comment 13

[Marco Chen [:mchen]]

Here is what I knew needs to apply to nexus 4 too.

Comment 14

[Marco Chen [:mchen]]

https://github.com/mozilla-b2g/gaia/pull/10783

Pull Request for Part 2 patch.

Comment 15

[Marco Chen [:mchen]]

Part 1 patch commit.
Master : 
https://github.com/mozilla-b2g/device-helix/commit/69175b75fde51c467e0132e737e898529c0d2173
1.1.0hd :
https://github.com/mozilla-b2g/device-helix/commit/5f26cae4487a65ba4fa2a3fa2f5f31c94b50fd20

Comment 16

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Part 2 master: https://github.com/mozilla-b2g/gaia/commit/1e8dfab984252468cb61e85963cf45f951004a6b

Comment 17

[Marco Chen [:mchen]]

https://github.com/mozilla-b2g/gaia/pull/10784

Pull Request for Part 2 patch on v1.1.0hd branch.

Comment 18

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Part 2 v1.1hd: https://github.com/mozilla-b2g/gaia/commit/6a8818ddd1aaab876a1ed22c519eec1fe9387c71

Thanks!!