Closed Bug 888841 Opened 6 years ago Closed 6 years ago

[helix] Need to set GAIA_DEV_PIXELS_PER_PX=1.5 for Gaia build process specifically for this device

Categories

(Firefox OS Graveyard :: Gaia, defect)

defect
Not set

Tracking

(blocking-b2g:hd+, firefox25 fixed, b2g18 wontfix, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix, b2g-v1.1hd fixed)

VERIFIED FIXED
blocking-b2g hd+
Tracking Status
firefox25 --- fixed
b2g18 --- wontfix
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- wontfix
b2g-v1.1hd --- fixed

People

(Reporter: timdream, Assigned: mchen)

References

Details

Attachments

(2 files, 3 obsolete files)

I believe I should add that somewhere in

https://github.com/mozilla-b2g/device-helix ?

Please help.
Flags: needinfo?(mchen)
Assignee: timdream → mchen
Attachment #769612 - Flags: feedback?(mwu)
Flags: needinfo?(mchen)
Hi :mwu,

From the request from gaia side, currently gaia needs to specify the scale value manually or gaia can't choose the correct image with correct resolution. So I add related definition into full_helix.mk and map to Android.mk of gaia.

Thanks.
Attachment #769625 - Flags: feedback+
Attachment #769625 - Flags: feedback+ → feedback?(mwu)
Attachment #769625 - Attachment is patch: true
Attachment #769625 - Attachment mime type: text/x-patch → text/plain
Comment on attachment 769612 [details] [diff] [review]
Part1 - To add a variable for gaia scaling value in full_helix.mk

Review of attachment 769612 [details] [diff] [review]:
-----------------------------------------------------------------

Approach looks fine. Not sure if the variable name is good, but I think you can debate that with whomever is reviewing the gaia side.
Attachment #769612 - Flags: feedback?(mwu) → feedback+
Comment on attachment 769625 [details] [diff] [review]
Part 2: To check and assign definition from full_helix.mk

Looks ok to me, though I don't think there should be a space after the comma on the ifneq line.
Attachment #769625 - Flags: feedback?(mwu)
Attachment #769993 - Flags: review? → review?(timdream)
Attachment #769625 - Attachment is obsolete: true
Comment on attachment 769993 [details] [diff] [review]
Part 2, v2: To check and assign definition from full_helix.mk

Looks alright, but can we NOT invent another variable "GAIA_DEFAULT_SCALE_VALUE"?
Attachment #769993 - Flags: review?(timdream)
Attachment #769993 - Flags: review+
Attachment #769993 - Flags: feedback?(mwu)
Comment on attachment 769993 [details] [diff] [review]
Part 2, v2: To check and assign definition from full_helix.mk

Looks like :mwu have already agreed with me on comment 3. Let's use the orignal variable name instead of GAIA_DEFAULT_SCALE_VALUE.
Attachment #769993 - Flags: feedback?(mwu)
Change the definition name to GAIA_DEV_PIXELS_PER_PX (the same name in Gaia).
Attachment #769612 - Attachment is obsolete: true
Attachment #770060 - Flags: review?(mwu)
Change the definition name to GAIA_DEV_PIXELS_PER_PX (the same name in Gaia).
Attachment #769993 - Attachment is obsolete: true
Attachment #770063 - Flags: review+
Blocks: 881126
No longer blocks: 881146
HD+ing as required
blocking-b2g: hd? → hd+
Hi Michael,

Could you help to review the patch of part 1?
Which had got the feedback+ from you and change the definition name align with Gaia side.

Thanks.
Flags: needinfo?(mwu)
Comment on attachment 770060 [details] [diff] [review]
Part1 v2 - To add a variable for gaia scaling value in full_helix.mk

r=me for this and any other similar fixes we need for other devices like Nexus 4.
Attachment #770060 - Flags: review?(mwu) → review+
Flags: needinfo?(mwu)
Here is what I knew needs to apply to nexus 4 too.
https://github.com/mozilla-b2g/gaia/pull/10783

Pull Request for Part 2 patch.
https://github.com/mozilla-b2g/gaia/pull/10784

Pull Request for Part 2 patch on v1.1.0hd branch.
Part 2 v1.1hd: https://github.com/mozilla-b2g/gaia/commit/6a8818ddd1aaab876a1ed22c519eec1fe9387c71

Thanks!!
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.