881146 - hdpi/xhdpi resolution assets and layout for First run experience app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This bug represents fixes needed in First run experience app in order to deliver bug 881126:

-- Have visual supply us with @1.5x and the correct @2x images.
-- On v1.1hd, modify CSS/JS so that apps will display @1.5x/@2x images correctly.
-- On master, drop the @1.5x and @2x images and make sure there is no
more to tweak besides changes made on bug 830644.

As HIDPI support never landed on v1-train, I expect the patch for both
branches on this bug will be different. The CSS/JS patch on v1.1hd will be based on the patch on master, but I won't expect it to be as simple as a |git cherry-pick|; so this is
where the engineering work lays.

The patch on top of v1-train should land on v1.1hd.

Comment 1

[Wayne Chang [:wchang]]

Setting hd+ for 1.1hd specific requirement

Comment 2

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: patch

This bug aims to achieve similar goal with bug 830644 on hd1.1.0 branch.
Since we need some specified step to try on WVGA device (partial can be tested
on Nightly), if you care about the changes and would like to do a full review,
you may set review flag after reviewing; otherwise, you may set feedback flag
and let me find an appropriate reviewer in Taipei to review and confirm on WVGA
device.
These 1.5x assets in patch are here temporarily for confirming we're making right
layout changes, and will be replaced later after visual team supplying newly made
1.5x assets.
The step for testing by HD is noted in Github comment. Feel free to ping me if you have any concerns. Thanks a lot!

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Hi folks,

Fernando went to PTO, if you want I can take care of reviwew for this, could you rebase the patch?

Thanks,
F.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Rex, see comment 3 above. Please rebase the patch, thank you!!

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Ouch, sorry I didn't noticed the update.

The patch has been rebased.
Splash screen in shared/resources/branding would be updated later in another bug.

Comment 6

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 770766 [details]
patch

Set reviewer to :arcturus. Thanks for your help!

I'll put a patch for master to add @1.5x assets later.

Comment 7

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: patch (master)

Patch for master.

This is mostly just adding assets because we already have hidpi patch for master, with just a few css modification.

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 770766 [details]
patch

Tried using the instructions using nightly.

Working well for normal and @1.5 images.

I have one question, I tried to try this in b2g desktop using the following command:

<path to b2g desktop> --screen=480x800@240 -profile <path to profile>

Any idea why?

Thanks

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 770766 [details]
patch

Anyway as I've tried on nightly :) r+plused.

Thanks a lot!

Comment 10

[KM Lee [:rexboy] (inactivate after Sep. 22)]

(In reply to Francisco Jordano [:arcturus] from comment #8)
> <path to b2g desktop> --screen=480x800@240 -profile <path to profile>
> 
> Any idea why?
> 
> Thanks

There are some known issues on detecting dppx in Gonk, but I'm not sure if it's related to desktop build. Sorry I didn't remember the bug number. I'll post it here if I find it.

Thank you for reviewing!

Comment 11

[KM Lee [:rexboy] (inactivate after Sep. 22)]

master
https://github.com/mozilla-b2g/gaia/commit/b10efa38ce6091d957ff0990696fbc401afb532d

v1.1.0hd
https://github.com/mozilla-b2g/gaia/commit/9d33b74591ce06f3187d5d4e13948a72ccbb858e