888908 - When the Navigation Bar is hidden the Click to Play dialog box appears when loading flash

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Marty]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:25.0) Gecko/20130701 Firefox/25.0 (Nightly/Aurora)
Build ID: 20130701024145

Steps to reproduce:

Disable Click to Play then hide the Navigation Bar. When attempting to load flash on any site a dialog box appears with the following text:

The doorhanger opens and says "'Adobe Flash' is enabled on youtube.com" / Block Plugin / Continue Allowing

Comment 1

[Phoenix]

Present in today trunk

Comment 2

[Benjamin Smedberg]

Attachment: When the location bar is missing, don't auto-popup the plugin notification (ever). It will still pop up when clicking the in-page UI. And Australis will make this code moot anyway

Comment 3

[Marty]

It might be moot in Australis however the bug will remain in 24ESR. This same bug is also affecting certain addons where the box appears even with the Navigation enabled, how would developers work around it? 

Please, it is extremely annoying to see this box with Click to Play disabled, how much time and effort would it take to fix it?

Comment 4

[Marty]

One more little caveat about this bug: if you do nothing with the box and simply make it go away by clicking on some other element in the page you can only load the current flash video. For example, on youtube you can load the current video however if you attempt another page's video you get nothing as flash won't load. The only fix is to close the browser and restart. That same problem also exists in Australis with the bug's infection into some addons.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 770332 [details] [diff] [review]
When the location bar is missing, don't auto-popup the plugin notification (ever). It will still pop up when clicking the in-page UI. And Australis will make this code moot anyway

Review of attachment 770332 [details] [diff] [review]:
-----------------------------------------------------------------

So this is basically backing out bug 831365. What has changed between then and now?

Comment 7

[Benjamin Smedberg]

There are two things different now:

1) clicking on the plugin is the primary way to get to the notification (because it no longer just plays a single instance)
2) We now show the notification when a plugin is enabled, and so the notification was popping up on most pages

Given this, the only case where a user with no location bar will have trouble is if there is a vulnerable *invisible* plugin. Fixing this any other way would require auto-popping the notification only if there is a CTP plugin, which would require early calculation of the plugin list and would be a performance issue.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 770332 [details] [diff] [review]
When the location bar is missing, don't auto-popup the plugin notification (ever). It will still pop up when clicking the in-page UI. And Australis will make this code moot anyway

Review of attachment 770332 [details] [diff] [review]:
-----------------------------------------------------------------

I guess in a way this is better because it removes code that only is working if the navigation bar is hidden, which will just be dead code anyways when Australis ships.

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Benjamin, what is the landing plan here?

Comment 10

[Benjamin Smedberg]

Need to do a try run with the other patches, then I'll roll up the landing.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Something in this push was causing mochitest-bc failures. Backed out.
http://hg.mozilla.org/integration/mozilla-inbound/rev/e6d3454da7a7

https://tbpl.mozilla.org/php/getParsedLog.php?id=25380390&tree=Mozilla-Inbound

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/62429a874f06

Comment 13

[Benjamin Smedberg]

Comment on attachment 770332 [details] [diff] [review]
When the location bar is missing, don't auto-popup the plugin notification (ever). It will still pop up when clicking the in-page UI. And Australis will make this code moot anyway

[Approval Request Comment]
See approval notes in bug 888292

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0883cacf940b

Comment 15

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed on Firefox 24 beta 1 (20130806170643).
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Firefox/24.0
Mozilla/5.0 (Machintosh; Intel Mac OS X 10.8; rv:24.0) Gecko/20100101 Firefox/24.0
Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Firefox/24.0

Comment 16

[Paul Silaghi, QA [:pauly]]

> When the location bar is missing, don't auto-popup the plugin notification (ever).
Will it ever auto-popup if the location bar is not missing ? Bug 810082, bug 819992 still apply?

Comment 17

[Georg Fritzsche [:gfritzsche]]

(In reply to Paul Silaghi [QA] from comment #16)
> > When the location bar is missing, don't auto-popup the plugin notification (ever).
> Will it ever auto-popup if the location bar is not missing ? Bug 810082, bug
> 819992 still apply?

We don't do auto-popups anymore, we only popup now for clicks on the notification icon or the in-page plugin overlay.

Comment 18

[Paul Silaghi, QA [:pauly]]

Verified fixed FF 25.0a2 (2013-08-18)