889233 - [A/V] Direct linked play cannot be resumed after it comes up from background

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect, P1)

Description

[leo.bugzilla.gecko]

STR
1. Play any direct linked audio/video file in the browser
2. while playing, push home button.
3. resume the browser

Then, player remains in black screen and user can control nothing.
I think this problem is solved as same way as Bug 887233.
(Restart over from the start)

Comment 1

[Punam Dahiya [:pdahiya]]

Failed to replicate the issue on 
07/02 - Gaia-Master - dd03227a854073efffaf0a024661cc54ef2ff508
Device- Unagi

Steps followed
1. Open dailymotion.com in browser
2. Click on any video under Buzz on the Daily Motion page.
3. Video starts playing in the browser.
4. Push home button. 
5. Tap on browser icon, opens the browser and video resumes playing in the browser

Is there any specific site, video that's giving this problem. Please provide the test video link/ browser URL and the device name. 

Thanks

Comment 2

[leo.bugzilla.gecko]

Could you(In reply to Punam Dahiya from comment #1)
> Failed to replicate the issue on 
> 07/02 - Gaia-Master - dd03227a854073efffaf0a024661cc54ef2ff508
> Device- Unagi
> 
> Steps followed
> 1. Open dailymotion.com in browser
> 2. Click on any video under Buzz on the Daily Motion page.
> 3. Video starts playing in the browser.
> 4. Push home button. 
> 5. Tap on browser icon, opens the browser and video resumes playing in the
> browser
> 
> Is there any specific site, video that's giving this problem. Please provide
> the test video link/ browser URL and the device name. 
> 
> Thanks

Could you please check by LEO device?
It doesn't resume the play and user cannot control player menu.

And this URL also. http://people.mozilla.org/~sikeda/

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

Black screen only occurs at Leo device. It's about the resource locking and releasing. In other devices, you may not suffer it, at least unagi and inari. If you have a Leo device, you may use YouTube to test it.

There is a patch, bug 881584, just landed to master and v1-train few days ago. It just closes the "view" activity of video app when you press home, power button, or get a incoming call. So, this bug will not be reproduced when you use latest v1-train.

BTW, if you really need this feature, I think it is fine to need info Firefox OS UX team(:fxosux).

Comment 4

[leo.bugzilla.gecko]

(In reply to John Hu [:johnhu] from comment #3)
> Black screen only occurs at Leo device. It's about the resource locking and
> releasing. In other devices, you may not suffer it, at least unagi and
> inari. If you have a Leo device, you may use YouTube to test it.
> 
> There is a patch, bug 881584, just landed to master and v1-train few days
> ago. It just closes the "view" activity of video app when you press home,
> power button, or get a incoming call. So, this bug will not be reproduced
> when you use latest v1-train.
> 
> BTW, if you really need this feature, I think it is fine to need info
> Firefox OS UX team(:fxosux).

The patch in Bug881584 is only for youtube.

What I tell in this case is not related to it.

In the case of youtube, browser uses player script in video application.
But in this case, browser uses inline player.

I know the video application already fixed the problem.
So i think, inline case should follow the same scenario, also.

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

Ok, I got it. You mean an inline player, not the view of video player. I will check the code about it. Thanks for your information.

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

Sorry about my comment 3.

It is browser inline player's bug. I had tested it with latest master in Inari device. It does not have the same issue, it just resumes playing while browser is reopened.

Comment 7

[Sotaro Ikeda [:sotaro]]

In the past, resume worked correctly. It regressed at some point. I am going to confirm what is blocking the resume playback.

Comment 8

[Sotaro Ikeda [:sotaro]]

It is regression of Bug 884182. It blocks normal transition from dormant to other state.

Comment 9

[Sotaro Ikeda [:sotaro]]

Attachment: patch - fix transition from dormant to other state

By applying the patch, confirmed that the problem is fixed on v1.1 unagi.

Comment 10

[Sotaro Ikeda [:sotaro]]

Attachment: patch v2 - Fix transition from dormant to other state

A patch for master. Carry "chris.double: review+".

Comment 11

[Sotaro Ikeda [:sotaro]]

Attachment: patch v2 for b2g18 - Fix transition from dormant to other state

A patch for b2g18. Carry "chris.double: review+".

Comment 12

[Sotaro Ikeda [:sotaro]]

https://tbpl.mozilla.org/?tree=Try&rev=c7f00f0a2418

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/projects/birch/rev/85180c0f4888

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/85180c0f4888

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/3baf8752a262

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/3baf8752a262