889384 - Windows desktop B2G build failure during webapp.zip packaging

Status: VERIFIED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Since we don't run dep builds for Windows builds (see bug 879370), all I can do is provide a regression range between the last good nightly and the broken one. I assume that someone will look into this promptly since these builds were deemed of high enough value to continue running. I also assume that nobody will object to mozilla-central remaining closed due to this even if bug 888765 is resolved in the mean time.
https://hg.mozilla.org/integration/gaia-central/pushloghtml?fromchange=c201d63425a6&tochange=b781d1e14fd8

https://tbpl.mozilla.org/php/getParsedLog.php?id=24829368&tree=Mozilla-Central

b2g_mozilla-central_win32_gecko nightly on 2013-07-02 04:46:04 PDT for push 4ffb23062b3b
slave: w64-ix-slave109

run-js-command  webapp-zip
make[7]: Leaving directory `/e/builds/moz2_slave/m-cen-w32_g-ntly-0000000000000/build/gaia'
e:\builds\moz2_slave\m-cen-w32_g-ntly-0000000000000\build\obj-firefox\b2g\gaia\Makefile:38:0: command 'make -j1 -C e:/builds/moz2_slave/m-cen-w32_g-ntly-0000000000000/build/gaia profile' failed, return code 2
e:\builds\moz2_slave\m-cen-w32_g-ntly-0000000000000\build\config\makefiles\target_libs.mk:59:0: command 'C:/mozilla-build/python27/python.exe e:/builds/moz2_slave/m-cen-w32_g-ntly-0000000000000/build/build/pymake/pymake/../make.py -C gaia libs' failed, return code 2
e:\builds\moz2_slave\m-cen-w32_g-ntly-0000000000000\build\config\makefiles\target_libs.mk:17:0: command 'C:/mozilla-build/python27/python.exe e:/builds/moz2_slave/m-cen-w32_g-ntly-0000000000000/build/build/pymake/pymake/../make.py -C b2g libs' failed, return code 2
evaluation from e:\builds\moz2_slave\m-cen-w32_g-ntly-0000000000000\build\config\rules.mk:746:24:23:0: command 'C:/mozilla-build/python27/python.exe e:/builds/moz2_slave/m-cen-w32_g-ntly-0000000000000/build/build/pymake/pymake/../make.py libs_tier_app' failed, return code 2
e:\builds\moz2_slave\m-cen-w32_g-ntly-0000000000000\build\config\rules.mk:680:0: command 'C:/mozilla-build/python27/python.exe e:/builds/moz2_slave/m-cen-w32_g-ntly-0000000000000/build/build/pymake/pymake/../make.py  tier_app' failed, return code 2
e:\builds\moz2_slave\m-cen-w32_g-ntly-0000000000000\build\client.mk:372:0: command 'C:/mozilla-build/python27/python.exe e:/builds/moz2_slave/m-cen-w32_g-ntly-0000000000000/build/build/pymake/pymake/../make.py -j4 -C obj-firefox' failed, return code 2
e:\builds\moz2_slave\m-cen-w32_g-ntly-0000000000000\build\client.mk:172:0: command 'C:/mozilla-build/python27/python.exe e:/builds/moz2_slave/m-cen-w32_g-ntly-0000000000000/build/build/pymake/pymake/../make.py -f e:/builds/moz2_slave/m-cen-w32_g-ntly-0000000000000/build/client.mk realbuild' failed, return code 2
build/utils.js:76: TypeError: dir is undefined
make[7]: *** [webapp-zip] Error 3

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Oh, and the corresponding Gecko regression range.
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d7553251cf43&tochange=4ffb23062b3b

Comment 2

[Dave Townsend [:mossop]]

Alex, think you can take a look at this?

Comment 3

[(not currently active) Ted Mielczarek]

Looking at where this is breaking this is almost certainly fallout from this gaia change:
https://github.com/mozilla-b2g/gaia/commit/e8191ba03a24507303515c58a61532868306fa8e#build/webapp-zip.js

Comment 4

[[:fabrice] Fabrice Desré]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #3)
> Looking at where this is breaking this is almost certainly fallout from this
> gaia change:
> https://github.com/mozilla-b2g/gaia/commit/
> e8191ba03a24507303515c58a61532868306fa8e#build/webapp-zip.js

That's right. And not the first time we get bitten by people using / in path and breaking windows builds :(

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Which begs the question of what revision we're actually building off since gaia.json and the logs say we're building off one that was prior to e8191ba03a24507303515c58a61532868306fa8e.

Comment 6

[Alexandre Poirot [:ochameau]]

Attachment: Pull request 10748

If I understood original patch correctly, that should fix this exception while doing the exact same thing.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

CCing aki. If PR10748 does fix this, that tells me that the Windows nightly b2g build wasn't actually using gaia.json like it claims to have been, which scares me :)

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 770278 [details]
Pull request 10748

Thanks!

Comment 9

[Alexandre Poirot [:ochameau]]

master: c8f3474fb73dfe2177ec908f0dcf914d7260248e

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Rex, please uplift this with bug 887742, thanks.

Comment 11

[Wayne Chang [:wchang]]

hd+ as required by bug 887742

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1hd: 43029b5a4743bb90280cd17901e7118aa26332c9