Closed
Bug 887742
Opened 11 years ago
Closed 11 years ago
GAIA_DEV_PIXELS_PER_PX param failed for assets in /shared/resources
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(blocking-b2g:hd+, b2g-v1.1hd fixed)
People
(Reporter: rexboy, Assigned: rexboy)
References
Details
Attachments
(1 file)
STR:
1. Add /shared/resources/branding/unofficial/logosmall@1.5x.png
2. run "make install-gaia APP=communications GAIA_DEV_PIXELS_PER_PX=1.5"
Expected:
logosmall@1.5x.png is packaged in application.zip as /shared/resources/branding/logosmall.png
Actual:
Neither logosmall@1.5x.png nor logosmall.png is included in zip file.
|
Assignee | |
Comment 1•11 years ago
|
||
Nominating hd? since apps using assets in resources/branding like Browser and FTU wouldn't get them properly.
blocking-b2g: --- → hd?
|
|
Assignee | |
Comment 2•11 years ago
|
||
This patch checks if HIDPI assets exists in shared/resources/branding additionally.
Attachment #768271 -
Flags: review?(timdream)
|
||
Updated•11 years ago
|
Attachment #768271 -
Flags: review?(timdream)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 768271 [details]
patch
Revised due to our discussion.
Would you take a look again?
Attachment #768271 -
Flags: review?(timdream)
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 768271 [details]
patch
Can you try my regexp? Thanks!
Attachment #768271 -
Flags: review?(timdream)
|
|
Assignee | |
Comment 5•11 years ago
|
||
Comment on attachment 768271 [details]
patch
Changes added.
Thank you!
Attachment #768271 -
Flags: review?(timdream)
|
|
||
Comment 6•11 years ago
|
||
Comment on attachment 768271 [details]
patch
Thanks!
Attachment #768271 -
Flags: review?(timdream) → review+
|
|
Assignee | |
Comment 7•11 years ago
|
||
Master:
https://github.com/mozilla-b2g/gaia/commit/6e78863eeff44198e76fae6ef501f9cb073e194e
Set to resolved fixed because landed in master, but I think we definitely need this for v1.1.0hd.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Comment 8•11 years ago
|
||
That's very likely the cause of bug 889384 because it's using hardcoded / in file paths (see https://github.com/mozilla-b2g/gaia/commit/e8191ba03a24507303515c58a61532868306fa8e#build/webapp-zip.js). Please don't do that.
|
|
Assignee | |
Comment 9•11 years ago
|
||
Hi Fabrice:
Sorry for that. I didn't notice problems on win32.
We need to uplift this to hd branch, so we may also need bug 889384 together.
ni Wayne.
Flags: needinfo?(wchang)
|
|
||
Comment 11•11 years ago
|
||
Please uplift this to v1.1hd, thanks!
status-b2g-v1.1hd:
--- → affected
Flags: needinfo?(rexboy)
|
||
Comment 13•11 years ago
|
||
This fix is responsible for the regression in bug 891395 - this completely break the phone for me.
|
||
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•