889501 - Purchasing pricetier 0 app for anonymous users fails with a 500

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Tester is not logged in
2. Find a price tier app on marketplace-dev (https://marketplace-dev.allizom.org/app/test-app-jgkjg/)
3. Click on the purchase button

expected behavior:
user is prompted to sign in within a trusted UI

observed behavior:
Install fails with "Error communicating with the server..."

headers:
03 E/GeckoConsole(  506): Content JS LOG at https://marketplace-dev-cdn.allizom.org/media/fireplace/js/include.js?b=1b0d9ae-51d31264:1 in anonymous: [req] Request failed:  INTERNAL SERVER ERROR
07-02 11:40:33.403 E/GeckoConsole(  506): Content JS LOG at https://marketplace-dev-cdn.allizom.org/media/fireplace/js/include.js?b=1b0d9ae-51d31264:1 in anonymous: [req] Error message:  Cannot assign None: "AddonPurchase.user" does not allow null values.
07-02 11:40:33.403 E/GeckoConsole(  506): Content JS ERROR at https://marketplace-dev-cdn.allizom.org/media/fireplace/js/include.js?b=1b0d9ae-51d31264:1 in anonymous: [install] Error installing app:  Could not generate receipt

Comment 1

[krupa raj[:krupa]]

ashes: 537a1

Comment 2

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/fireplace/commit/3ee43d6
https://github.com/mozilla/fireplace/commit/a87668a

The API should never 500 from bad data - we should probably file separately for that though.

Comment 3

[krupa raj[:krupa]]

Now, there is no 500 and the user is logged in but the install doesn't start after logging in.

Comment 4

[krupa raj[:krupa]]

(In reply to krupa raj[:krupa] from comment #3)
> Now, there is no 500 and the user is logged in but the install doesn't start
> after logging in.

ashes ID: c37e2

Comment 5

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/fireplace/commit/80353ee

Comment 6

[Iulian Timis]

The user is now prompted to sign in via Persona, but the app install fails, and the following message is displayed "Install failed. Please try again later."
Log ID: 9f7a7

Comment 7

[Christopher Van Wiemeersch [:cvan]]

Works for me - can someone verify please?

Comment 8

[krupa raj[:krupa]]

wfm too

Iulian, what server were you testing this on and what app did you use?

Comment 9

[Iulian Timis]

(In reply to krupa raj[:krupa] from comment #8)
> wfm too
> 
> Iulian, what server were you testing this on and what app did you use?

I used the app from the STR https://marketplace-dev.allizom.org/app/test-app-jgkjg/ on MP-dev app on Unagi